Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhanced undo ctrl panel #6545

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: enhanced undo ctrl panel #6545

wants to merge 26 commits into from

Conversation

giuliaghisini
Copy link
Contributor

@giuliaghisini giuliaghisini commented Dec 17, 2024 •
edited
Loading

Enhanced Undo controlpanel.

Now it displays a loader while waiting for transactions from Plone.
When you want to delete some transaction, a confirm popup asks the user to confirm undo action for selected items.
Changed columns width to better display path.
Added select-all.
Added pagination.
Added OP column.
Added some translations.

Registrazione.schermo.2024-12-19.alle.12.43.49.mov

Enlarged the width of container in controlpanels, to have more horizontal space.
Unified the controlpanel's look to have same layout, some controlpanel had old layout, like

  • Content types
  • Moderate comments
  • Relations
    controlpanels.
undo.mov

Is it possibile to cherry-pick this PR in 17.x.x ?

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit d970c09
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6777cb8289bcbb0008c818f5

@stevepiercy
Copy link
Collaborator

For accessibility, the issue of standardizing colors came up in:

The topic was added as an item to the PLIP.

@stevepiercy stevepiercy requested a review from a team December 18, 2024 12:20
@giuliaghisini
Copy link
Contributor Author

For accessibility, the issue of standardizing colors came up in:

The topic was added as an item to the PLIP.

ok, ill'remove this fixes

stevepiercy
stevepiercy requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comments on the .pot file to apply throughout the .po files, and expand the change log entry.

packages/volto/locales/volto.pot Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Show resolved Hide resolved
packages/volto/locales/volto.pot Show resolved Hide resolved
packages/volto/news/6545.feature Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

ok, ill'remove this fixes

I think it's OK to leave them in, so we can see what you came up with and discuss it. I did not mean for you to delete them. Sorry for the miscommunication.

giuliaghisini and others added 13 commits December 18, 2024 16:22
@giuliaghisini
added pagination, select all, column op
694f944
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
9d1e688 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
d74a86b 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
82e2122 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
b699284 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
035ff9f 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
192c0df 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
6e30272 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
44e74d9 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
b74a9b5 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/locales/volto.pot
34a0def 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini @stevepiercy
Update packages/volto/news/6545.feature
d12a7ad 
Co-authored-by: Steve Piercy <[email protected]>
@giuliaghisini
fix: translations
5cadfd1
@giuliaghisini
Copy link
Contributor Author

ok, ill'remove this fixes

I think it's OK to leave them in, so we can see what you came up with and discuss it. I did not mean for you to delete them. Sorry for the miscommunication.

don't worry. I prefered to remove that styles because out of this pr. It's better to manage a11y styles in a single consistent pr.

@tisto
Copy link
Member

tisto commented Jan 2, 2025

@giuliaghisini amazing work! Thank you, Giulia!

This might be beyond the scope of this enhancement. However, I think we need to broaden the width of the control panels in Volto. The undo control panel, the redirection control panel, and other control panels that display lots of data in a table just do not have sufficient space. cc @sneridagh

@giuliaghisini
Copy link
Contributor Author

This might be beyond the scope of this enhancement. However, I think we need to broaden the width of the control panels in Volto. The undo control panel, the redirection control panel, and other control panels that display lots of data in a table just do not have sufficient space. cc

i agree... had some difficults to gain width for path column..
maybe... for all controlpanels.. we could think to enlarge 'contents' width to 80% of monitor width for example..

@giuliaghisini
Copy link
Contributor Author

@giuliaghisini amazing work! Thank you, Giulia!

This might be beyond the scope of this enhancement. However, I think we need to broaden the width of the control panels in Volto. The undo control panel, the redirection control panel, and other control panels that display lots of data in a table just do not have sufficient space. cc @sneridagh

@tisto
Copy link
Member

tisto commented Jan 3, 2025

@giuliaghisini @sneridagh I would increase the size of the main area to 90% at least if that's technically possible. The control panels are for power users and they need as much space as possible.

@giuliaghisini giuliaghisini reopened this Jan 3, 2025
@giuliaghisini
Copy link
Contributor Author

giuliaghisini commented Jan 3, 2025 •
edited
Loading

@giuliaghisini @sneridagh I would increase the size of the main area to 90% at least if that's technically possible. The control panels are for power users and they need as much space as possible.

@tisto @sneridagh
i've updated this pr where i have increased the width of controlpanels.
I've updated the description and the example video of this PR if you want to check the result

@tisto
Copy link
Member

tisto commented Jan 3, 2025

@giuliaghisini looks great! Can wait to see this PR merged and released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy requested changes

@cekk cekk Awaiting requested review from cekk

@pnicolli pnicolli Awaiting requested review from pnicolli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giuliaghisini @stevepiercy @tisto