Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncing conda recipe when dependencies in setup.py change #19

Open
edublancas opened this issue Jan 29, 2023 · 4 comments
Open

syncing conda recipe when dependencies in setup.py change #19

edublancas opened this issue Jan 29, 2023 · 4 comments

Comments

@edublancas
Copy link
Contributor

I realized that when we update dependencies in the setup.py (example), the PR that the bot opens for conda-forge does not update them - so we need to fix this.

the PR will break when new dependencies are added, removed but it'll pass when an existing dependencies is changed. e.g., from pkg>=1 and pkg>=2

@edublancas
Copy link
Contributor Author

looks like this is what want: https://twitter.com/condaforge/status/1647933355877445633

@edublancas
Copy link
Contributor Author

example:

this is the PR that the conda bot opened: conda-forge/jupysql-feedstock#10

it didn't update the dependencies: https://github.com/ploomber/jupysql/blob/ca49215ae5bcb43822c76c7ebb22cfe430550127/setup.py#L21

cc @idomic

@edublancas
Copy link
Contributor Author

applied this to the jupysql recipe, will propagate to other packages if it works well: https://github.com/conda-forge/jupysql-feedstock/blob/main/conda-forge.yml

@idomic
Copy link
Contributor

idomic commented Apr 30, 2023

Cool let's see if it reduces the overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants