Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatibility with matplotlib 3.7 #47

Open
edublancas opened this issue Feb 16, 2023 · 0 comments
Open

incompatibility with matplotlib 3.7 #47

edublancas opened this issue Feb 16, 2023 · 0 comments

Comments

@edublancas
Copy link
Contributor

Our tests started failing with matplotlib 3.7, I tracked down the error locally:

# ensure you're running matplotlib 3.7
pip install matplotlib -U

# run tests
pytest tests --ignore=tests/test_engine.py

the error is happening in the test_no_outputs test. Upon execution, this is how the notebook looks like:

image

there's a clear error here since the first cell x = 1 should not produce any outputs; yet, it displays a plot. Seems like with the new matplotlib release, we need to do some "matplotlib state cleaning" when destroying the shell object, so when creating a new one, we don't share state from previous notebook runs. My guess is that we're missing something here

It's still unclear what changed in matplotlib 3.7 so more investigation is needed. for the time being, I pinned matplotlib so our tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant