Enable or disable stacking based on MSPT hysteresis #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/uk/antiperson/stackmob/mspt/SparkMsptProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/antiperson/stackmob/mspt/SparkMsptProvider.java
Outdated
Show resolved
Hide resolved
|
I applied all the mentioned changes. Thanks for the quick review. |
|
I've been testing this for a week so far on my server (https://minecraft-mp.com/server/323715/stats/) and I haven't seen any issues. The stacking does make a positive effect on the server with the current setup. |
| @@ -19,6 +19,23 @@ public MergeTask(StackMob sm) { | |||
| } | |||
|
|
|||
| private void checkEntity(StackEntity original, boolean checkHasMoved, double checkHasMovedDistance) { | |||
| if(original.getEntityConfig().isMsptReactiveEnabled()){ | |||
There was a problem hiding this comment.
Is it likely that this would need to be enabled/disabled on a per entity type basis? Because at the moment this is doing the check for each entity, when it could just be checked once at the beginning of the task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a feature that enables stacking only when the server is under heavy load. When the server load decreases (due to hysteresis effects, meaning it has improved its initial threshold), stacking will be automatically disabled.
Key Points:
Additional Changes: