From 1a2c1a2f1a702a0105e2dc79d546670d1c8df71a Mon Sep 17 00:00:00 2001
From: Leah Amelia Chen <hi@pluie.me>
Date: Fri, 13 Dec 2024 09:20:58 +0100
Subject: [PATCH] yesplaymusic: drop

It seems like YesPlayMusic has been effectively abandoned upstream with numerous usability
and API bugs preventing it from working, while using old, unsupported Node versions (14 and 16)
and Electron versions (22).

While there have been forks and projects created in its image
(see https://github.com/qier222/YesPlayMusic/issues/2344), it would be better
if we drop YesPlayMusic first, and package any fork that manages to garner enough momentum.

Part of #296939
---
 pkgs/by-name/ye/yesplaymusic/package.nix | 144 -----------------------
 pkgs/top-level/aliases.nix               |   1 +
 2 files changed, 1 insertion(+), 144 deletions(-)
 delete mode 100644 pkgs/by-name/ye/yesplaymusic/package.nix

diff --git a/pkgs/by-name/ye/yesplaymusic/package.nix b/pkgs/by-name/ye/yesplaymusic/package.nix
deleted file mode 100644
index 78b47a99ac996..0000000000000
--- a/pkgs/by-name/ye/yesplaymusic/package.nix
+++ /dev/null
@@ -1,144 +0,0 @@
-{
-  lib,
-  stdenv,
-  fetchurl,
-  _7zz,
-  dpkg,
-  autoPatchelfHook,
-  wrapGAppsHook3,
-  makeWrapper,
-  alsa-lib,
-  at-spi2-atk,
-  cups,
-  nspr,
-  nss,
-  mesa, # for libgbm
-  xorg,
-  xdg-utils,
-  libdrm,
-  libnotify,
-  libsecret,
-  libuuid,
-  gtk3,
-  systemd,
-}:
-let
-  pname = "yesplaymusic";
-  version = "0.4.8-2";
-
-  srcs =
-    let
-      version' = lib.head (lib.splitString "-" version);
-    in
-    {
-      x86_64-linux = fetchurl {
-        url = "https://github.com/qier222/YesPlayMusic/releases/download/v${version}/yesplaymusic_${version'}_amd64.deb";
-        hash = "sha256-iTWi+tZGUQU7J1mcmMdlWXSKpYGy4mMAeq9CN9fhnZ8=";
-      };
-      aarch64-linux = fetchurl {
-        url = "https://github.com/qier222/YesPlayMusic/releases/download/v${version}/yesplaymusic_${version'}_arm64.deb";
-        hash = "sha256-PP0apybSORqleOBogldgIV1tYZqao8kZ474muAEDpd0";
-      };
-      x86_64-darwin = fetchurl {
-        url = "https://github.com/qier222/YesPlayMusic/releases/download/v${version}/YesPlayMusic-mac-${version'}-x64.dmg";
-        hash = "sha256-UHnEdoXT/vArSRKXPlfDYUUUMDyF2mnDsmJEjACW2vo=";
-      };
-      aarch64-darwin = fetchurl {
-        url = "https://github.com/qier222/YesPlayMusic/releases/download/v${version}/YesPlayMusic-mac-${version'}-arm64.dmg";
-        hash = "sha256-FaeumNmkPQYj9Ae2Xw/eKUuezR4bEdni8li+NRU9i1k=";
-      };
-    };
-  src =
-    srcs.${stdenv.hostPlatform.system} or (throw "Unsupported system: ${stdenv.hostPlatform.system}");
-
-  libraries = [
-    alsa-lib
-    at-spi2-atk
-    cups
-    nspr
-    nss
-    mesa
-    xorg.libxshmfence
-    xorg.libXScrnSaver
-    xorg.libXtst
-    xdg-utils
-    libdrm
-    libnotify
-    libsecret
-    libuuid
-    gtk3
-  ];
-
-  meta = with lib; {
-    description = "Good-looking third-party netease cloud music player";
-    mainProgram = "yesplaymusic";
-    homepage = "https://github.com/qier222/YesPlayMusic/";
-    license = licenses.mit;
-    maintainers = with maintainers; [ ChaosAttractor ];
-    platforms = builtins.attrNames srcs;
-  };
-in
-if stdenv.hostPlatform.isDarwin then
-  stdenv.mkDerivation {
-    inherit
-      pname
-      version
-      src
-      meta
-      ;
-
-    nativeBuildInputs = [
-      _7zz
-      makeWrapper
-    ];
-
-    sourceRoot = ".";
-
-    installPhase = ''
-      runHook preInstall
-
-      mkdir -p $out/Applications
-      cp -r *.app $out/Applications
-
-      makeWrapper $out/Applications/YesPlayMusic.app/Contents/MacOS/YesPlayMusic $out/bin/yesplaymusic
-
-      runHook postInstall
-    '';
-  }
-else
-  stdenv.mkDerivation {
-    inherit
-      pname
-      version
-      src
-      meta
-      ;
-
-    nativeBuildInputs = [
-      autoPatchelfHook
-      wrapGAppsHook3
-      makeWrapper
-      dpkg
-    ];
-
-    buildInputs = libraries;
-
-    runtimeDependencies = [
-      (lib.getLib systemd)
-    ];
-
-    installPhase = ''
-      runHook preInstall
-
-      mkdir -p $out/bin
-      cp -r opt $out/opt
-      cp -r usr/share $out/share
-      substituteInPlace $out/share/applications/yesplaymusic.desktop \
-        --replace "/opt/YesPlayMusic/yesplaymusic" "$out/bin/yesplaymusic"
-      makeWrapper $out/opt/YesPlayMusic/yesplaymusic $out/bin/yesplaymusic \
-        --argv0 "yesplaymusic" \
-        --add-flags "$out/opt/YesPlayMusic/resources/app.asar"
-
-      runHook postInstall
-    '';
-  }
diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix
index b545420485728..2d09412a40938 100644
--- a/pkgs/top-level/aliases.nix
+++ b/pkgs/top-level/aliases.nix
@@ -1422,6 +1422,7 @@ mapAliases {
   ### Y ###
 
   yacc = throw "'yacc' has been renamed to/replaced by 'bison'"; # Converted to throw 2024-10-17
+  yesplaymusic = throw "YesPlayMusic has been removed as it was broken, unmaintained, and used deprecated Node and Electron versions"; # Added 2024-12-13
   yafaray-core = libyafaray; # Added 2022-09-23
   youtrack_2022_3 = throw "'youtrack_2022_3' has been removed as it was deprecated. Please update to the 'youtrack' package."; # Added 2024-10-17
   yrd = throw "'yrd' has been removed, as it was broken and unmaintained"; # added 2024-05-27