Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-built mac app? #8

Open
justgage opened this issue Jun 19, 2018 · 3 comments
Open

pre-built mac app? #8

justgage opened this issue Jun 19, 2018 · 3 comments

Comments

@justgage
Copy link

I love this timer, however it's a bit hard to get other people to download it in the current state.

I had to downgrade to npm version 8.1.0 to get it to work for what it's worth.

@allan-stewart
Copy link
Contributor

allan-stewart commented Jun 22, 2018

Hi @justgage , we're glad to hear that you are enjoying the timer, but sorry you had trouble getting it to work. Let's tackle that first.

Build Issue
Your message wasn't clear on what the problem was. I assume you meant that you had to downgrade to node v8.1.0 rather than npm since the latest npm is only v6.1.0. So I tried building against several versions of node/npm (thanks nvm).

Node v8.9.4 (w/ npm 5.6.0) worked fine for me.
Node v8.11.3 (w/ npm 5.6.0) also worked fine; this is the latest LTS version.

But node v10.5.0 (w/ npm 6.1.0) failed due to an electron-packager error:

> electron-packager . --platform=darwin --arch=x64 --out=dist --icon=icon --overwrite

CANNOT RUN WITH NODE 10.5.0
Electron Packager requires Node 4.0 or above.

So I pushed an update to the electron-packager (commit 9026ca9) and then it worked for all three versions without any problem on my end.

Does that change fix the problem for you as well? If not, could you provide more detail on the problem you are encountering?

Pre-built Apps
I like the idea of providing pre-built versions of the mob-timer, but it would add some overhead to contributing to the project. I'm not sure how well I'd trust an electron build for another platform (e.g. build for Linux from Windows) so we'd have to test that out; or else we'd have to build for every platform.

So I'm a little wary of adding that extra work. Would that extra work be worth the benefit, or do most teams prefer to build the timer themselves (which also lends itself to customizing / hacking on the timer if they want)?

I'll ask around the office (we have multiple teams that use this timer) to see what they think. If other timer users want to comment or 👍 this issue, I'd love to get that feedback.

@justgage
Copy link
Author

I think for our proposes we use mac exclusively, as long as it can build on most NPM versions it's probably not a big deal.

@dignite
Copy link
Contributor

dignite commented Nov 30, 2018

I have a Proof of Concept here that I would like some feedback on: dignite#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants