Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid edge reported for self-complemental nodes #48

Open
sebschmi opened this issue May 4, 2021 · 2 comments
Open

Invalid edge reported for self-complemental nodes #48

sebschmi opened this issue May 4, 2021 · 2 comments
Labels

Comments

@sebschmi
Copy link
Contributor

sebschmi commented May 4, 2021

Consider the following input reference file:

a.fa

>a
CGCGG

Using the command line Bifrost build -k 4 -r a.fa -o a on the current master of this repo yields the following result:

a.gfa

H	VN:Z:1.0	BV:Z:1.0.5	KL:Z:4	ML:Z:2
S	1	CGCGG
L	1	-	1	+	3M

The reverse complement of S1 is CCGCG, which does not overlap in three characters with CGCGG. So the edge L1 must be wrong.

Note that the node CGCG is self-complemental.

@GuillaumeHolley
Copy link
Collaborator

Thanks for reporting this issue, I'll investigate asap. I wouldn't be surprise that that the issue is related to the very small k-mer size, I don't remember testing that edge case. Did you have the same issue with larger k-mers (k=5,6)?

@sebschmi
Copy link
Contributor Author

sebschmi commented May 4, 2021

Thank you for the quick answer.

Thank you for the quick response.

I get the same issue for k=30 with the following input reference: CCCCCCCCCCCCCCGCGGGGGGGGGGGGGGG (13 Cs attached to the front and 13 Gs attached to the back of the original string)

It is not possible to create the same test-case with uneven k, as then there would not be any self-complemental nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants