Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI dlopen example #10

Merged
merged 2 commits into from
Aug 11, 2022
Merged

ABI dlopen example #10

merged 2 commits into from
Aug 11, 2022

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Apr 5, 2022

No description provided.

@jjhursey jjhursey requested review from raffenet, rhc54 and dsolt April 5, 2022 19:06
@jjhursey
Copy link
Member Author

jjhursey commented Apr 5, 2022

Depends on #9 (which is also shown in this PR).

@jjhursey
Copy link
Member Author

jjhursey commented Apr 6, 2022

Rebased now that PR #9 has been merged.

@jjhursey jjhursey force-pushed the abi-dlopen-example branch from 2652436 to 2bddff3 Compare April 6, 2022 11:53
Copy link
Contributor

@raffenet raffenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion to fix a warning.

example/abi-query-dlopen.c Outdated Show resolved Hide resolved
@jjhursey jjhursey force-pushed the abi-dlopen-example branch from 2bddff3 to 5fc9d39 Compare April 11, 2022 18:06
@jjhursey jjhursey force-pushed the abi-dlopen-example branch from 5fc9d39 to 960dff4 Compare April 12, 2022 16:06
Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey jjhursey force-pushed the abi-dlopen-example branch from 960dff4 to 716e752 Compare June 7, 2022 01:41
@jjhursey
Copy link
Member Author

jjhursey commented Jun 7, 2022

I just force pushed to this branch to update the example to reflect the stable/provisional split in the current proposal (pmix/pmix-standard#397). The OpenPMIx implementation is here: openpmix/openpmix#2617

@jjhursey
Copy link
Member Author

Per IAWG meeting July 11, 2022:

  • We should add a lookup table in the base README.md to mark the version pairing on the PMIx Standard with the PMIx ABI.
  • Once PMIx Standard of v5.0 is released then we will mark the stable and provisional ABI to v1.0.
  • (Josh) Will add to this PR the README.md table

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Member Author

I just pushed the first draft of the version table to this PR. It looks like:
image

@jjhursey
Copy link
Member Author

All PMIx Governance and PMIx Standard items have been merged for the ABI. We can merge this now and update the README.md with any notes necessary when we release the PMIx Standard v5.0.

@jjhursey jjhursey merged commit 8bcad05 into pmix:main Aug 11, 2022
@jjhursey jjhursey deleted the abi-dlopen-example branch August 11, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants