Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PMIX_QUERY_ABI_VERSION #397

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Add PMIX_QUERY_ABI_VERSION #397

merged 3 commits into from
Aug 11, 2022

Conversation

jjhursey
Copy link
Member

  • Ref Issue Defining a PMIx ABI #365
  • Add a PMIX_QUERY_ABI_VERSION attribute that can be passed to
    PMIx_Query_info to access the ABI version implementated by the
    associated PMIx library.

@jjhursey jjhursey added this to the PMIx v5 Standard milestone Mar 15, 2022
@jjhursey jjhursey mentioned this pull request Mar 15, 2022
12 tasks
@jjhursey
Copy link
Member Author

jjhursey commented Mar 15, 2022

Left to do:

  • Implement this in OpenPMIx for folks to experiment with.
  • Post an example of how this attribute could be used. Maybe as a use case?

@rhc54
Copy link
Member

rhc54 commented Mar 15, 2022

Implement this in OpenPMIx for folks to experiment with.

The query_info functions currently rely on the proc having called PMIx_Init first. I'd suggest just having those functions start by doing a quick check for this attribute and responding immediately if found so you don't require the "init".

@jjhursey
Copy link
Member Author

That's a good idea. I've added some text in the latest commit to account for that.

Chap_API_Sync_Access.tex Outdated Show resolved Hide resolved
@jjhursey
Copy link
Member Author

jjhursey commented Apr 5, 2022

I filed the implementation of this in openpmix/openpmix#2551 with some examples in the examples/ directory.

@jjhursey
Copy link
Member Author

jjhursey commented Apr 5, 2022

@jjhursey jjhursey marked this pull request as ready for review April 11, 2022 22:30
@jjhursey
Copy link
Member Author

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so
    we know your current thoughts
  • Not all proposals solve exactly the same problem, so we may end
    up accepting proposals that appear to have some overlap
    This is not a binding majority-rule vote, but it will be a very
    significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

  • Hooray or Rocket: I support this so strongly that I
    want to be an advocate for it
  • Heart: I think this is an ideal solution
  • Thumbs up: I'd be happy with this solution
  • Confused: I'd rather we not do this, but I can tolerate it
  • Thumbs down: I'd be actively unhappy, and may even consider
    other technologies instead
    If you want to explain in more detail, feel free to add another
    comment, but please also vote on this comment.

@jjhursey jjhursey added RFC Request for Comment Eligible Eligible for consideration by ASC labels Apr 11, 2022
Chap_API_Sync_Access.tex Outdated Show resolved Hide resolved
@jjhursey
Copy link
Member Author

I just pushed an additional commit to split the stable and provisional into two attributes.
The link to the versioning section is in a comment because it depends on PR #375 - we will address that at a later stage.

@jjhursey
Copy link
Member Author

PMIx ASC 2Q 2022

  • Passed the first vote: 8 yes / 0 no / 3 abstain
  • This is eligible for second vote in the 3Q 2022 ASC quarterly meeting

@jjhursey
Copy link
Member Author

jjhursey commented Jun 7, 2022

@jjhursey
Copy link
Member Author

PMIx ASC 3Q 2022

  • Passed the second vote: 8 yes / 0 no / 0 abstain
  • This will be included in the next major release.

@jjhursey jjhursey added the Accepted as Stable ASC second vote passed. Accepted as Stable! label Aug 11, 2022
 * Ref Issue pmix#365
 * Add a `PMIX_QUERY_ABI_VERSION` attribute that can be passed to
   `PMIx_Query_info` to access the ABI version implementated by the
   associated PMIx library.
 * Add init/finalize exception for some attributes passed to query

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Member Author

Rebased branch. The only new addition was the last commit (per discussion with the group) to add a cross-reference to the versioning language which was brought in as part of PR #375.

@jjhursey jjhursey merged commit e8f55e1 into pmix:master Aug 11, 2022
@jjhursey jjhursey deleted the abi-query branch August 11, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted as Stable ASC second vote passed. Accepted as Stable! Eligible Eligible for consideration by ASC First Vote Passed ASC first vote passed RFC Request for Comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants