Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support eslint v9 flat config #50

Closed
dzcpy opened this issue Jul 25, 2024 · 7 comments · Fixed by #53
Closed

Support eslint v9 flat config #50

dzcpy opened this issue Jul 25, 2024 · 7 comments · Fixed by #53
Labels
help wanted Extra attention is needed

Comments

@dzcpy
Copy link

dzcpy commented Jul 25, 2024

No description provided.

@0xbdm0101
Copy link

image
Oops! Something went wrong! :(
"eslint": "^9.9.0",

@dai-shi
Copy link
Member

dai-shi commented Nov 5, 2024

Would anyone like to take this?

@dai-shi dai-shi added the help wanted Extra attention is needed label Nov 5, 2024
@barelyhuman
Copy link
Collaborator

I'll pick it up, we will need to change a few things in the rule's defs as well so might as well do it as one version

@dai-shi do we want to keep supporting v8?

@dai-shi
Copy link
Member

dai-shi commented Nov 5, 2024

Nice. I don't know about v8 compatibility, but to be honest, I'm still on v8.

@barelyhuman
Copy link
Collaborator

I'll try to keep compat but if it doesn't work we'll just have to maintain 2 versions, cause I'm on v8 in most projects as well

@barelyhuman barelyhuman mentioned this issue Nov 5, 2024
Merged
3 tasks
@dai-shi
Copy link
Member

dai-shi commented Nov 6, 2024

Can anyone help testing #53?

@barelyhuman
Copy link
Collaborator

https://github.com/pmndrs/eslint-plugin-valtio/releases/tag/v0.7.0

Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): support for v9 configs pmndrs/eslint-plugin-valtio
4 participants
@dzcpy @dai-shi @0xbdm0101 @barelyhuman