From 2e7d5d6acecfde2a2a91eb5d3bccf4979e321d1d Mon Sep 17 00:00:00 2001 From: Kris Baumgartner Date: Thu, 22 Jun 2023 12:21:39 -0700 Subject: [PATCH] fix: object3d check in reconciler --- packages/fiber/src/core/reconciler.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/fiber/src/core/reconciler.ts b/packages/fiber/src/core/reconciler.ts index 6983ed9581..a3bdc6f1b0 100644 --- a/packages/fiber/src/core/reconciler.ts +++ b/packages/fiber/src/core/reconciler.ts @@ -112,7 +112,7 @@ function handleContainerEffects(parent: Instance, child: Instance, beforeChild?: // Append instance if (child.props.attach) { attach(parent, child) - } else if (child.object instanceof THREE.Object3D && parent.object instanceof THREE.Object3D) { + } else if (isObject3D(child.object) && isObject3D(parent.object)) { if (beforeChild) { child.object.parent = parent.object parent.object.children.splice(parent.object.children.indexOf(beforeChild.object), replace ? 1 : 0, child.object)