Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected publicly documented methods of ArcballControls to be public #382

Open
IkonOne opened this issue Oct 22, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@IkonOne
Copy link

IkonOne commented Oct 22, 2024

  • three version: ^0.164.1
  • @types/three version: ^0.164.1
  • three-stdlib version: ^2.30.1

Problem description:

Many public and documented methods on ArcballControls are marked private in three-stdlib.

Relevant code:

...

Suggested solution:

Replace the private access modifier with public.

Are these marked private intentionally?

@IkonOne IkonOne added the bug Something isn't working label Oct 22, 2024
@IkonOne
Copy link
Author

IkonOne commented Oct 22, 2024

related: #372

@IkonOne
Copy link
Author

IkonOne commented Oct 22, 2024

I think this is just an oversight. Can someone please confirm that it is and I can make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant