Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant operations in code generated by the TTGT pass #29

Open
pthomadakis opened this issue Sep 21, 2023 · 0 comments
Open

Redundant operations in code generated by the TTGT pass #29

pthomadakis opened this issue Sep 21, 2023 · 0 comments
Assignees
@pthomadakis

Comments

@pthomadakis
Copy link
Collaborator

The code generated by the TTGT pass can, in some cases, create redundant transpose operations.
@pthomadakis pthomadakis changed the title Generated code for TTGT optimization Redundant operation in code generated by the TTGT pass Sep 21, 2023
@pthomadakis pthomadakis changed the title Redundant operation in code generated by the TTGT pass Redundant operations in code generated by the TTGT pass Sep 21, 2023
pthomadakis added a commit that referenced this issue Sep 27, 2023
@pthomadakis
This commit partially addresses issue #29.
a6c415c 
  When one or more tensors are transposed before a contraction (C=A*B), the shape of the contraction result
  might be different than the expected output C. Thus this intermediate results is stored in a temporary tensor,
  which will later be tranposed in the C, taking the expected shape.
  However, instead of just allocating this intermediate tensor we would also transpose tensor C into it, making
  a redundant trasposition. This commit removes this extra transposition.
pthomadakis added a commit that referenced this issue Oct 12, 2023
@pthomadakis
Fix redundant traspose in TCtoTTGT pass (#36)
de06e82 
This commit partially addresses issue #29.

  When one or more tensors are transposed before a contraction (C=A*B), the shape of the contraction result
  might be different than the expected output C. Thus this intermediate results is stored in a temporary tensor,
  which will later be tranposed in the C, taking the expected shape.
  However, instead of just allocating this intermediate tensor we would also transpose tensor C into it, making
  a redundant trasposition. This commit removes this extra transposition and maintains it only for the case of C+=,-= 
  A*B.
pthomadakis added a commit that referenced this issue Oct 22, 2023
@pthomadakis
Fix redundant traspose in TCtoTTGT pass (#36)
37f8cd9 
This commit partially addresses issue #29.

  When one or more tensors are transposed before a contraction (C=A*B), the shape of the contraction result
  might be different than the expected output C. Thus this intermediate results is stored in a temporary tensor,
  which will later be tranposed in the C, taking the expected shape.
  However, instead of just allocating this intermediate tensor we would also transpose tensor C into it, making
  a redundant trasposition. This commit removes this extra transposition and maintains it only for the case of C+=,-= 
  A*B.
pthomadakis added a commit that referenced this issue Oct 22, 2023
@pthomadakis
Fix redundant traspose in TCtoTTGT pass (#36)
bddd3b7 
This commit partially addresses issue #29.

  When one or more tensors are transposed before a contraction (C=A*B), the shape of the contraction result
  might be different than the expected output C. Thus this intermediate results is stored in a temporary tensor,
  which will later be tranposed in the C, taking the expected shape.
  However, instead of just allocating this intermediate tensor we would also transpose tensor C into it, making
  a redundant trasposition. This commit removes this extra transposition and maintains it only for the case of C+=,-= 
  A*B.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pthomadakis pthomadakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pthomadakis