Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of 'minsize' restriction for enrichment_in_sets (Script: enrichment_in_groups.R) #43

Open
HarkiratSohi opened this issue Apr 28, 2023 · 1 comment

Comments

@HarkiratSohi
Copy link
Collaborator

HarkiratSohi commented Apr 28, 2023

I noticed the output for enrichment_in_sets doesn't restrict the analysis to the default "minsize = 5" (# of members in the overlap of interest?) or any other specified value of minsize. Currently, there is no check for minsize for the code corresponding to the Fisher's test in enrchiment_in_groups.R.

Need to add checking of minsize (input parameter specified in the enrichment_in_sets method in leapR) in enrichment_in_groups.R for the block of code under " if (method == "fishers"){ "

@HarkiratSohi
Copy link
Collaborator Author

Also add clear documentation for what minsize represents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant