Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateTypicalBuilding using deprecated model_standards_climate_zone method #15

Open
eringold opened this issue Oct 1, 2024 · 5 comments
Assignees

Comments

@eringold
Copy link

eringold commented Oct 1, 2024

In openstudio-standards v0.6.0 this:

climate_zone = standard.model_standards_climate_zone(model)

was changed to OpenstudioStandards::Weather::model_get_climate_zone

@lymereJ
Copy link
Contributor

lymereJ commented Oct 1, 2024

Thanks @eringold! @jugonzal07 - Are you able to make the change?

@jugonzal07
Copy link
Collaborator

Thanks all, that shouldn't be a major change.

@jugonzal07
Copy link
Collaborator

@eringold -- could we provide backwards capability with something similar to this? (If I recall, openstudio-standards v0.6.0 was added in OpenStudio v3.8.0):

      if model.version < OpenStudio::VersionString.new('3.8.0')
        climate_zone = standard.model_standards_climate_zone(model)
      else
        climate_zone = OpenstudioStandards::Weather.model_get_climate_zone(model)
      end

I figure that might help folks that haven't updated yet.

@eringold
Copy link
Author

eringold commented Oct 9, 2024

@jugonzal07 I think that would work. You could also check the openstudio-standards version directly with OpenstudioStandards::VERSION

@jugonzal07
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants