Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged Packet Version Number (3 bits) and Packet Identifier (13 bits) #10

Open
pasetti opened this issue Jan 7, 2023 · 1 comment
Open
Assignees

Comments

@pasetti
Copy link
Contributor

pasetti commented Jan 7, 2023

The rejection reports in service 1 carry the following two parameters:

  • Packet Version Number (3 bits) of TC being rejected
  • Packet Identifier (13 bits) of TC being rejected

These parameters are currently treated as separate parameters for which dedicated getter and setter methods are provided. The new Cordet FW Editor, however, does not handled parameters with size below one byte. Hence, the two parameters are treated as one single parameter called Ver:VersNmbPcktId.

In order to maintain compatibility with the editor output, I need to replace references to the getter and setter methods for the 'Packet Version Number' and 'Packet Identifier' functions with references to the getter and setter methods for parameter 'Ver:VersNmbPcktId'. The changes must be done in the following functions:

  • /src/Ver/CrPsCmdPrgrFailFunc.c
  • ./src/Ver/CrPsPcktReroutingFailFunc.c
  • ./src/Ver/CrPsCmdVerSuccFunc.c
  • ./src/Ver/CrPsCmdVerFailFunc.c
  • ./src/Ver/CrPsCmdPrgrSuccFunc.c
@pasetti pasetti self-assigned this Jan 7, 2023
@pasetti
Copy link
Contributor Author

pasetti commented Jan 7, 2023

The functions in the Ver service have been modified as indicated above. The compilation errors have disappeared but I leave the ticket open because the new implementation still needs to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant