Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance spo user ensure with more options #6181

Open
milanholemans opened this issue Jul 25, 2024 · 3 comments · May be fixed by #6426
Open

Enhance spo user ensure with more options #6181

milanholemans opened this issue Jul 25, 2024 · 3 comments · May be fixed by #6426
Assignees
@nanddeepn
Labels
enhancement work in progress

Comments

@milanholemans
Copy link
Contributor

milanholemans commented Jul 25, 2024 •
edited
Loading

Currently, the command spo user ensure accepts two options: user ID and user UPN.
However, there can/should be more options, for example, to ensure Entra groups.

I suggest we add the following options:

Option Description
--loginName [loginName] The login name of the principal. Specify either loginName, entraId, userName, entraGroupId, or entraGroupName.
--entraGroupId [entraGroupId] ID of the Microsoft Entra group. Specify either loginName, entraId, userName, entraGroupId, or entraGroupName.
--entraGroupName [entraGroupName] Display name of the Microsoft Entra group. Specify either loginName, entraId, userName, entraGroupId, or entraGroupName.

Let's also add some extra examples, e.g.:

m365 spo user ensure --webUrl https://contoso.sharepoint.com/sites/Marketing --loginName "c:0t.c|tenant|e08e899f-ba40-4e91-ab36-44d4fbaa454e"
m365 spo user ensure --webUrl https://contoso.sharepoint.com/sites/Marketing --loginName "i:0#.f|membership|[email protected]"
m365 spo user ensure --webUrl https://contoso.sharepoint.com/sites/Marketing --entraGroupId e08e899f-ba40-4e91-ab36-44d4fbaa454e
m365 spo user ensure --webUrl https://contoso.sharepoint.com/sites/Marketing --entraGroupName "Marketing team"
@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Jul 25, 2024
@Jwaegebaert Jwaegebaert added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jul 26, 2024
@nanddeepn
Copy link
Contributor

Can I work on this?

@Adam-it Adam-it added the hacktoberfest Issue perfect for hacktoberfest label Sep 24, 2024
@nanddeepn
Copy link
Contributor

Can I work on this?

@milanholemans
Copy link
Contributor Author

Sure, thanks!

@nanddeepn nanddeepn linked a pull request Oct 12, 2024 that will close this issue
Open
@Adam-it Adam-it removed the hacktoberfest Issue perfect for hacktoberfest label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanddeepn nanddeepn

Labels
enhancement work in progress
Projects
None yet
Milestone
No milestone
4 participants
@nanddeepn @milanholemans @Jwaegebaert @Adam-it