Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defining default properties from commands that are not returning a list #6432

Open
26 tasks
Adam-it opened this issue Oct 16, 2024 · 1 comment · May be fixed by #6441
Open
26 tasks

Remove defining default properties from commands that are not returning a list #6432

Adam-it opened this issue Oct 16, 2024 · 1 comment · May be fixed by #6441
Assignees
@SmitaNachan
Labels
enhancement work in progress

Comments

@Adam-it
Copy link
Member

Adam-it commented Oct 16, 2024

We should use defaultProperties method only when the command is of list type so returns more than one item. It should rather not be used in get, add or any other commands.

We could fix it up in the following cases:

  • entra user guest add
  • flow get
  • flow environment get
  • flow run get
  • pa app get
  • pa environment get
  • planner bucket add
  • planner plan add
  • planner plan get
  • planner plan set
  • planner task checklistitem add
  • pp aibuildmodel get
  • pp card get
  • pp chatbot get
  • pp dataverse table get
  • pp environment get
  • pp solution get
  • pp solution publisher get
  • spo group member add
  • spo page copy
  • spo page get
  • tenant serviceannouncement health get
  • todo list get
  • todo task get
  • viva engage message add
  • viva engage message get
@Adam-it Adam-it added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Oct 16, 2024
@milanholemans milanholemans added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Oct 17, 2024
@SmitaNachan
Copy link
Contributor

Can I work on it?

@SmitaNachan SmitaNachan linked a pull request Oct 20, 2024 that will close this issue
Draft
@Adam-it Adam-it added hacktoberfest Issue perfect for hacktoberfest and removed hacktoberfest Issue perfect for hacktoberfest labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SmitaNachan SmitaNachan

Labels
enhancement work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes defaultProperties method from various commands. Closes #6432 SmitaNachan/cli-microsoft365
3 participants
@milanholemans @Adam-it @SmitaNachan