Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Calendar Feed web part to latest version of SPFx - Refresh Rangers Hacktoberfest Event #5239

Open
Adam-it opened this issue Sep 29, 2024 · 9 comments
Assignees
Labels
Good First Issue 🏆 hacktoberfest sample: react-calendar-feed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail.

Comments

@Adam-it
Copy link
Member

Adam-it commented Sep 29, 2024

🎯Aim

The aim of this issue is to upgrade the Calendar Feed web part sample to the latest version of SPFx (1.20)

🤔 Tips how to get started

To support you in this issue you may use the below tooling:

📣 What's this event all about

Refresh Rangers is a unique Hacktoberfest event aiming to update our most popular samples 🚀.
During this, you may obtain a unique Microsoft 365 & Power Platform Community badge - Refresh Rangers 🎖️
To obtain this badge besides opening a PR you also need to opt-in the Microsoft 365 & Power Platform Community Recognition Program and fill out this form

@petkir
Copy link
Contributor

petkir commented Oct 6, 2024

i'll take it @Adam-it

@Adam-it Adam-it added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed Help wanted 🪧 labels Oct 7, 2024
@Adam-it
Copy link
Member Author

Adam-it commented Oct 7, 2024

i'll take it @Adam-it

all yours 👏👏👏👏

@Adam-it
Copy link
Member Author

Adam-it commented Oct 29, 2024

@petkir what is the status on this one?
The event is ending with October and this will mean that this won't count toward the Hacktoberfest event if you participated in this one (here there is nothing we may do about it)
BUT a PR for this issue will be created even after October this will still count to get the Refresh Ranger badge from the Microsoft 365 and Power Platform Community

@petkir
Copy link
Contributor

petkir commented Oct 29, 2024

@Adam-itit's coming only Outlook feed is missing the other 3 providers work already. give me some time for the PR

@petkir
Copy link
Contributor

petkir commented Nov 1, 2024

Hi @Adam-it

Currently, the following providers are implemented:

  • SharePoint: Same domain requests are working.
  • iCAL / RSS / WordPress: Mostly functional, but dependent on CORS settings.
  • Exchange Calendar Feed: Not working due to CORS issues.

Problem Description:

Originally, to avoid CORS problems, a proxy provider was used, but it returns Access-Control-Allow-Origin: *.
This does not accapt my Edge Browser on a SharePoint Page.
When I set the fetch mode to mode:'no-cors', I receive a successful response of type response.type === 'opaque'.
While this allows me to download the data to the client, but I'm unable to manipulate the data using JavaScript.

I have experimented with other proxy providers and various Edge plugins, but none have proven to be effective solutions.

One potential solution I see is starting a web browser on localhost to make the request. However, there are no existing examples in this sample gallery that include an additional Azure function or something else.

on the other hand removing support for the Exchange Calendar Feed is also a solution, as it is referred to as the Exchange Public Calendar so ...

So what do you think @Adam-it : self-hosted proxy or remove the Exchange iCal support?

after playing hours i would remove the support for EX, because this is a thing of minutes.

@Adam-it
Copy link
Member Author

Adam-it commented Nov 7, 2024

@petkir sorry for the late reply 🙏 and thank you for an awesome analysis on this and sum up.
TBH I am also not sure what would be the most preferable approach and I would leave it to the authors of this sample to decide. From what I see it is you and @hugoabernier so... 🙂
But If you want any feed from my side I would suggest the easiest path possible so for now removing the support to Exchange iCal. Usually when a sample is to complex and requires additional setup which is not described in the readme or added with the sample then it is rather not usable. Ideally a sample should be easy to start, use, and extend for your needs if someone will want to do that.

@hugoabernier
Copy link
Collaborator

I am OK with removing the support for Exchange

@petkir
Copy link
Contributor

petkir commented Nov 26, 2024

I will do it next week thanks @hugoabernier

@Adam-it
Copy link
Member Author

Adam-it commented Dec 22, 2024

hey @petkir there is no pressure or priority on this issue but I was wondering if you have any updates on this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue 🏆 hacktoberfest sample: react-calendar-feed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail.
Projects
None yet
Development

No branches or pull requests

3 participants