Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple permissions display & fixes property pane bugs #5353

Open
ferrarirosso opened this issue Nov 24, 2024 · 1 comment · May be fixed by #5355
Open

Add multiple permissions display & fixes property pane bugs #5353

ferrarirosso opened this issue Nov 24, 2024 · 1 comment · May be fixed by #5355
Labels
sample: react-securitygrid type:enhancement Idea for enhancing a sample

Comments

@ferrarirosso
Copy link

Disclaimer

Yes

Sample

https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-securitygrid

Contributor(s)

Russel Gove

Suggestion

  1. When configuring multiple permissions for display, only the last clicked permission button is currently taken into account. Sometimes, the user has to disable all other permission buttons to display the correct one. I will fix this issue so that the web part displays all selected permissions simultaneously.

  2. After upgrading to version 1.20, the property pane settings may not synchronize correctly when changing the permission settings.

Are you willing to help?

Yes
@ferrarirosso ferrarirosso added the type:enhancement Idea for enhancing a sample label Nov 24, 2024
@ferrarirosso
Copy link
Author

Assign this issue to me, thx

ferrarirosso pushed a commit to ferrarirosso/sp-dev-fx-webparts that referenced this issue Nov 28, 2024
Fixes pnp#5353:Property pane bug + add multiple permissions to display
15aa42b
@ferrarirosso ferrarirosso linked a pull request Nov 28, 2024 that will close this issue
Open
9 tasks
@ferrarirosso ferrarirosso removed their assignment Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sample: react-securitygrid type:enhancement Idea for enhancing a sample
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 5353 ferrarirosso/sp-dev-fx-webparts
2 participants
@ferrarirosso @hugoabernier