💡 [Feature]: Remove or Refactor the show/hide tenant wide extension list

[Adam-it]

🎯 Aim of the feature

Since now the list of extensions only loads when the node is expanded to ensure that the additional API calls don't affect the extension load time there is little sense in having the setting that allows to show/hide the extension list. We could consider the following:

• removing this setting. This may seem a breaking change and maybe we should consider doing it with next major v5 release which should also bring multiple connections. This release is a bit blocked due to ESM support (different issue/story 😛)
• refactoring this setting to something more global. It could now allow to either show(load)/hide apps from all app catalogs. So when set to true all app catalogs will be expandable and will show the app list. When set to true we would only show app catalogs without the possibility to show apps

📷 Images (if possible) with expected result

The issue relates to the following setting:

🤔 Additional remarks or comments

Related issue #215

Tagging @Saurabh7019 as initial author of this idea 👍. You Rock 🤩

Prototype

1. we should rename this setting and correct its description
   

   vscode-viva/package.json

   Lines 187 to 191 in 5919011

   	"spfx-toolkit.showTenantWideExtensions": {
   	"title": "Show tenant-wide extensions",
   	"type": "boolean",
   	"default": true,
   	"description": "Show the tenant-wide extensions in the account view."

   
   it should be something like Show apps in app catalogs and description like When set it will load all apps in every app catalog on your tenant
2. we should remove this

   vscode-viva/src/panels/CommandPanel.ts

   Line 176 in 5919011

   const showTenantWideExtensions: boolean = getExtensionSettings<boolean>('showTenantWideExtensions', true);

   and just always load the tenant wide extensions
3. we should use the new setting here

   vscode-viva/src/panels/CommandPanel.ts

   Line 200 in 5919011

   const tenantAppCatalogNode = new ActionTreeItem(tenantAppCatalogUrl.replace(origin, '...'), '', { name: 'globe', custom: false }, TreeItemCollapsibleState.Collapsed, 'vscode.open', `${Uri.parse(tenantAppCatalogUrl)}/AppCatalog`, 'sp-app-catalog-url', undefined,

   and it similar place in site app catalogs so that when this setting is set to false we should not make it expandable and not add the expand handle
4. this setting should be true by default

[nicodecleyre]

Hi, @Adam-it, just wondering. You define in the last bullet point 2 scenarios 'when set to true'. I was wondering if it shouldn't be:

• When set to true, all app catalogs will be expandable and display the app lists.
• When set to false, only the catalogs themselves will be visible, without the option to expand and view individual apps.

[Adam-it]

Hi, @Adam-it, just wondering. You define in the last bullet point 2 scenarios 'when set to true'. I was wondering if it shouldn't be:

• When set to true, all app catalogs will be expandable and display the app lists.
• When set to false, only the catalogs themselves will be visible, without the option to expand and view individual apps.

Yes exactly that is what I had in mind 👍. Thank you for clarifying

[Adam-it]

Ok let's get this shipped and not wait for a major release, this settings don't make much sense anyway.
I will create some prototype to guide how to go about it and then let's open it up

[Adam-it]

I added a prtotype with guidance how to go about it in the orginal issue post. Let's open it up for others 🚀