Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior for guessing suite_num #15

Open
artemijan opened this issue Jan 14, 2019 · 2 comments
Open

Incorrect behavior for guessing suite_num #15

artemijan opened this issue Jan 14, 2019 · 2 comments

Comments

@artemijan
Copy link

Hello,
there is a case for this address '268 S Beverly Dr. #9876'
This address is parsed and suite_num is None.
I've found the reason
Take a look:
elif len(word_lw) > 0 and word_lw[0] == '#' and res['suite_num'] is not None
should be without "not" statement
elif len(word_lw) > 0 and word_lw[0] == '#' and res['suite_num'] is None
What do you think?

@pnpnpn
Copy link
Owner

pnpnpn commented Jan 14, 2019

Yeah, you are right. It's better to test that both suite type and name are None.

Can you create a pull request? Thanks.

@artemijan
Copy link
Author

Yes, I will try to do it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants