Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findCommonTiming - unexpected output #7

Open
pnutzz-0207 opened this issue Apr 16, 2022 · 1 comment
Open

findCommonTiming - unexpected output #7

pnutzz-0207 opened this issue Apr 16, 2022 · 1 comment

Comments

@pnutzz-0207
Copy link
Owner

pnutzz-0207 commented Apr 16, 2022

UG did not specify what happens when multiple tags given in findCommonTiming.
Screenshot 2022-04-16 at 3.09.26 PM.png

When findCommonTiming t/friends t/family da/2022-04-16 given, the output is:
Screenshot 2022-04-16 at 3.10.28 PM.png

Only the last tag given is taken into consideration.

@nus-se-script
Copy link

nus-se-script commented Apr 19, 2022

Team's Response

image.png

Note the third point and the fifth point of this section of the UG. As there is no ... in the findCommonTiming explanation (see screenshot below), only the last tag should be considered, which is the expected behaviour of UniGenda.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

UG - not detailed enough for findCommonTiming

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



UG did not specify what will happen when multiple tags are entered. Actual result is that only the last tag will be processed.
Screenshot 2022-04-16 at 3.20.33 PM.png


[original: nus-cs2103-AY2122S2/pe-interim#2851] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Note the third point and the fifth point of this section of the UG. As there is no ... in the findCommonTiming explanation, only the last tag should be considered, which is the expected behaviour of UniGenda.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue type

Team chose [type.DocumentationBug]
Originally [type.FeatureFlaw]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants