Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving PlayerPosition typealias to tuple[float, float, float] #251

Closed
adisujithkumar opened this issue Jun 9, 2023 · 0 comments · Fixed by #270
Closed

Moving PlayerPosition typealias to tuple[float, float, float] #251

adisujithkumar opened this issue Jun 9, 2023 · 0 comments · Fixed by #270

Comments

@adisujithkumar
Copy link
Collaborator

PlayerPosition is a new typealias introduced in the first map control PR. Currently the type is a list[float], such that it can be easily used with find_closest_area. However, it seems better to typealias PlayerPosition with tuple[float, float, float]. This issue was created to track the work done later to make this change.
@adisujithkumar adisujithkumar changed the title Moving PlayerPosition type to tuple[float, float, float] Moving PlayerPosition typealias to tuple[float, float, float] Jun 9, 2023
@JanEricNitschke JanEricNitschke linked a pull request Jul 28, 2023 that will close this issue
Changed PlayerPosition to tuple[float, float, float] #270
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed PlayerPosition to tuple[float, float, float] JanEricNitschke/csgo
1 participant
@adisujithkumar