feat(HMS-2997): wizard notifications #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Added notifications for cancealling and finishing a wizard. The notification for cancel is a bit different then drafted in HMS-2997 as the cancellation process is removing the registered domain so in most cases it should end with the same result. Signed-off-by: Petr Vobornik <[email protected]>
pvoborni
force-pushed
the
notifications-wizard
branch
from
1c5d38a to
0278a5a
Compare
pvoborni
commented
May 2, 2024
avisiedo
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thanks for the change; I have only one comment, but for me it is approved.
The change are working as indicated.
About the question of the notification, I think is a good question for UXD mates.
The notification situation is addressed in a different ticket.
Checked the behavior locally.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notifications for cancelling and finishing a wizard.
The notification for cancel is a bit different then drafted in
HMS-2997 as the cancellation process is removing the registered
domain so in most cases it should end with the same result.
Rebased on top of #55
Demo: https://drive.google.com/file/d/1wj6n70VCWuHjensaz_JqM6hh6uze5BE8/view?usp=drive_link
In the demo we can see that the notifications did not disappear in some cases. I think this is connected with the way how the notification middleware/redux store is registered + navigation between pages. But I don't have a fix for it yet. Commit 463f9a8 had some possitive effect in pr 55 but not much in the registration workflow.