Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HMS-2721): integrate check permissions #65

Merged
merged 3 commits into from
May 30, 2024

Conversation

avisiedo
Copy link
Contributor

@avisiedo avisiedo commented May 15, 2024

This change is build on top of #64.

This change provide the specific hook to check
the idmsvc permissions so this can be used
broadly on the whole UI.

@avisiedo avisiedo self-assigned this May 15, 2024
@avisiedo avisiedo marked this pull request as draft May 15, 2024 10:22
@app-sre-bot
Copy link

Can one of the admins verify this patch?

@avisiedo avisiedo force-pushed the hms-2721-rbac-ui-2 branch 2 times, most recently from 810d0c9 to 60563a8 Compare May 21, 2024 19:00
avisiedo added 2 commits May 23, 2024 19:22
This change add the useIdmPermissions which is used to
check the required permissions on the UI.

Signed-off-by: Alejandro Visiedo <[email protected]>
This change add the rbac checks to the app context,
making them broadly available on the frontend
application.

Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo changed the title feat(HMS-2721): generate rbac client api feat(HMS-2721): integrate check permissions May 27, 2024
Add steps to install nvm command and set up the node version
to develop with the repository.

Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo marked this pull request as ready for review May 29, 2024 08:26
@avisiedo avisiedo force-pushed the hms-2721-rbac-ui-2 branch from 60563a8 to d135576 Compare May 29, 2024 17:49
Copy link
Contributor

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avisiedo avisiedo merged commit 200b969 into podengo-project:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants