Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-4126: update some strings #66

Merged
merged 1 commit into from
May 16, 2024

Conversation

frasertweedale
Copy link
Contributor

Update some UI text for correctness or clarity.

@app-sre-bot
Copy link

Can one of the admins verify this patch?

@avisiedo avisiedo self-requested a review May 15, 2024 23:20
Copy link
Contributor

@avisiedo avisiedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 👍

Allmost LGTM only two concerns about leverage <strong> and &quot;.

@frasertweedale
Copy link
Contributor Author

I removed the quotes and just use <strong> to highlight the domain name.

Update some UI text for correctness or clarity.
@frasertweedale frasertweedale enabled auto-merge (rebase) May 16, 2024 05:30
@avisiedo avisiedo self-requested a review May 16, 2024 06:40
Copy link
Contributor

@avisiedo avisiedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frasertweedale frasertweedale merged commit 22df354 into podengo-project:main May 16, 2024
1 check passed
@frasertweedale frasertweedale deleted the string-review branch May 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants