Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with esbuild server port #44

Open
digitalsadhu opened this issue Apr 11, 2023 · 1 comment
Open

bug with esbuild server port #44

digitalsadhu opened this issue Apr 11, 2023 · 1 comment

Comments

@digitalsadhu
Copy link
Member

occasionally, shutting down the server results in the esbuild server still locking its port. Running killall esbuild resolves this but it would be nice to anticipate and handle this within the podlet server.

@trygve-lie
Copy link
Contributor

I think we should move the hot reload out of esbuild and into the fastify server it self. This will require a small change in how we listen and serve some files plus we will need to add a part which pushes hints about file changes.

I have actually written a plugin for this which we can add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants