Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect translation in French #173

Open
narFnarF opened this issue Aug 18, 2019 · 2 comments
Open

Incorrect translation in French #173

narFnarF opened this issue Aug 18, 2019 · 2 comments

Comments

@narFnarF
Copy link
Contributor

When transferring to iTunes, the link to visit the iTunes website has incorrect translation in French.

Steps to reproduce:

  1. On desktop computer (I used Windows 10), click the Subscribe button in the Subscribe widget.
  2. Select iTunes
  3. Ignore the prompt to launch iTunes (close it) and go back to the Subscribe widget.
  4. Look at the text under the Retry button

Current text:
Visite iTunes du site internet

Expected text:
Visiter le site d'iTunes

Screenshot:
https://i.imgur.com/hQjGlzC.png

@saerdnaer
Copy link
Collaborator

Can you modify the corresponding strings here https://github.com/podlove/podlove-subscribe-button/blob/master/src/coffee/translations.coffee#L162-L186 (e.g. via GitHub's edit function) and create a PR?

@narFnarF
Copy link
Contributor Author

narFnarF commented Jan 30, 2020

I just submitted a PR. It's kinda the first time I've done this so tell me if I did it correctly or if there's something I need to do differently. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants