Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Running e2e tests (playwright) on mac close app function is not closing app properly #160

Open
adrianriobo opened this issue Apr 11, 2024 · 7 comments
Assignees
Labels
bug Something isn't working os/macos

Comments

@adrianriobo
Copy link
Contributor

When running the playwright e2e tests on MacOS when the app is closed in between tests somehow the system has a problem on how the app is closed and a popup is showing.

image

This is preventing new executions of pipelines which are based on goax as it will use the forefront app to install Podman, but the forefront app is now this warning popup.

Ideally the e2e execution should leave the environment as it was before execution.

@adrianriobo adrianriobo added os/macos bug Something isn't working labels Apr 11, 2024
@odockal
Copy link
Contributor

odockal commented Apr 11, 2024

I have found quite good looking, in a way of problematic, description and possible solution to a problem here:
https://stackoverflow.com/questions/68750716/electron-app-throwing-quit-unexpectedly-error-message-on-mac-when-quitting-the-a

@adrianriobo
Copy link
Contributor Author

Also a quick dirty solution in the meantime would be to reboot the machine as the last command on the script. When the machine is started after the reboot there are no popups.

This solution will not fix this issue but will unblock us for scheduled the execution of the pipeline. Specially if this can not be addressed right now and this may hit all the e2e for any extension we want to test. WDYT?

@odockal
Copy link
Contributor

odockal commented Apr 11, 2024

if that works, no problem.
I believe there could be a solution to this, we just need to make sure to clean up all running processes from podman-desktop/node/electron before closing the app itself. I have to write some trial/failure snippets to the listener available on the electronApp, which would be the best solution.

@odockal
Copy link
Contributor

odockal commented Apr 11, 2024

shouldn't be logging out the user enough?

@adrianriobo
Copy link
Contributor Author

Not sure, but the point is, if you reboot the underlying deliverest logic will wait until the machines comes up so you dont have to log in and log out (as that would require probably to move the user password somehow to the script)

And as pre requisite target hosts have auto login set up so you do not need to take care of nothing just add the reboot cmd on your script

@odockal
Copy link
Contributor

odockal commented Jul 1, 2024

Might have been fixed by podman-desktop/podman-desktop#7803

@odockal odockal self-assigned this Jul 4, 2024
@odockal odockal moved this to 🚥 In Review in Podman Desktop Planning Jul 4, 2024
@odockal odockal assigned odockal and unassigned odockal Jul 4, 2024
@odockal
Copy link
Contributor

odockal commented Jul 25, 2024

I am still seeing the problematic pop ups. But we might now know the place to tackle in development mode in order to avoid this windows being shown on every test run on mac.

@odockal odockal moved this from 🚥 In Review to ⏱Postponed in Podman Desktop Planning Jul 25, 2024
@odockal odockal moved this from ⏱Postponed to 🚥 In Review in Podman Desktop Planning Aug 7, 2024
@odockal odockal moved this from 🚥 In Review to ⏱Postponed in Podman Desktop Planning Aug 26, 2024
@odockal odockal moved this from ⏱Postponed to 📋 Backlog in Podman Desktop Planning Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working os/macos
Projects
None yet
Development

No branches or pull requests

2 participants