Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Single Point of Build #168

Open
adrianriobo opened this issue Apr 18, 2024 · 4 comments
Open

[Enhancement] Single Point of Build #168

adrianriobo opened this issue Apr 18, 2024 · 4 comments

Comments

@adrianriobo
Copy link
Contributor

The idea is to avoid duplication and over computation across the podman desktop ecosystem, each extension to be tested requires the latest build of Podman Desktop built for development.

As so instead of add that building process across each pipeline/flow on each platform / component there will be one flow doing it on each merge on main branch for Podman Desktop that will send an event to a webhook on podman-desktop-e2e which will trigger a build of the development version and packetize it to be then reused from any other flow / pipeline

podman-desktop-testing drawio

@adrianriobo
Copy link
Contributor Author

Side note if use deliverest as base image for them we will have something to directly copy the development version to a target host

@adrianriobo
Copy link
Contributor Author

Should we keep the same version of PD during a extension PR life cycle @benoitf (i.e even if we manage to use pre-release versions of PD, should we lock the PR pre release version to run the PR until it got merged?)

@benoitf
Copy link
Contributor

benoitf commented Apr 25, 2024

@adrianriobo

how would it be possible to change the version of Podman Desktop during the test of an extension PR ?

you mean, if someone add a new commit later to the PR of an extension, maybe during that time Podman Desktop had new commits ?

I would assume that each new run (after commit/amend) on the extension PR will fetch the current main build of Podman Desktop

@adrianriobo
Copy link
Contributor Author

Yeah exactly; lets imagine I create a PR on a extension today and it is tested against the current pre-released version of PD on gh; them tomorrow a new commit (or force push) comes into the extension PR and the pipeline is triggered, by then maybe there is a different latest pre- release vearion of PD on gh.... as so the PR will be tested against a different PD version.

I would assume that each new run (after commit/amend) on the extension PR will fetch the current main build of Podman Desktop

I think the same, there should not be an issue having different PD versions on each PR run, as code should not be dependent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants