Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stanza does not add npm packages to package.json that were included via data-component-imports statements #35

Closed
dvmorris opened this issue Jun 13, 2016 · 2 comments

Comments

@dvmorris
Copy link

dvmorris commented Jun 13, 2016

If you include a data-component-imports attribute on a component in WebFlow as described in the reacterminator docs here, stanza includes the import statements at the top of the component file, but it does not add the corresponding npm packages to package.json.

Perhaps it is too complex for stanza to be responsible for this in addition to everything else it is doing, but it would be helpful for the script to at least output to the console a message that says something like,

Some of the generated components are importing custom npm packages. Be sure to add the correct versions of these packages to package.json:
- moment
- ...
- etc.
@dvmorris
Copy link
Author

I apologize for putting this in the wrong repository. This is really a reacterminator issue.

@Chun-Yang
Copy link
Contributor

Port it to poetic/reacterminator#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants