Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A webflow export with apostrophes as html property values will break stanza update #57

Open
JohnRodney opened this issue Sep 20, 2016 · 5 comments

Comments

@JohnRodney
Copy link
Contributor

<input autofocus="autofocus" class="input-field w-input" data-name="What&#39;s your address?" id="What-s-your-address" maxlength="256" name="What-s-your-address" placeholder="What&#39;s your address?" required="required" type="text">

In the case of a designer setting up a placeholder with a apostrophe the output webflow ends up using an html entity value which in turn breaks reacterminator from doing an update.

I'm not sure what the best solution here is but it would seem it would be to ask the designer not to use apostrophe's but in the case of trying to provide correct grammar for a input placeholder you would want this. Any ideas @Chun-Yang?

@Chun-Yang
Copy link
Contributor

Chun-Yang commented Sep 20, 2016

This is related to the the html parser I think. For now let's not use html entities there.

@JohnRodney
Copy link
Contributor Author

@Chun-Yang so then the expected solution is for a third party aka a developer to convert these by hand before doing an update?

@JohnRodney
Copy link
Contributor Author

Also I can move this issue to reacterminator if you would like I just put it here since it applies to how webflow does an export.

@Chun-Yang
Copy link
Contributor

That would be great 👍

@Chun-Yang
Copy link
Contributor

Reacterminator should fix it eventually. Ideally it should only be an option in the parser in reacterminator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants