Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action creator into Param Store #32

Open
Chun-Yang opened this issue Jul 19, 2016 · 1 comment
Open

Add action creator into Param Store #32

Chun-Yang opened this issue Jul 19, 2016 · 1 comment

Comments

@Chun-Yang
Copy link
Contributor

  1. add action creator into ParamStore
  2. change Link component to accept the store?
  3. change reacterminator so that it use the new syntax?
  4. minimize API, remove setAll and getAll?
@Chun-Yang
Copy link
Contributor Author

Right now, we pass store to ParamStore and use ParamStore as an action emitter. It seems a more 'redux' way to do it is to use an action creator. In another term, the API we have in ParamStore is leaky.

Also, ParamStore's api is leaky for another reason: we still use 'window.history.back' instead of something like 'ParamStore.back'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant