Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RequestConfiguration is set to inappropriate default value #103

Open
abcjjy opened this issue Jun 3, 2024 · 2 comments
Open

[BUG] RequestConfiguration is set to inappropriate default value #103

abcjjy opened this issue Jun 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@abcjjy
Copy link

abcjjy commented Jun 3, 2024

Godot version

4.2.2

Plugin version

v3.1.1

Phone information

iPhone X iOS 14.8

Issue description

Following values are set to -1 as default in godot scripts. And these values are passed to Admob SDK directly, which causes the personalized ad is disabled and revenue loss. Unspecified values can not be set through this api.

Take Admob Unity plugin as a reference. It converts these values to native constants in ObjC code explicitly.

int tagForChildDirectedTreatment = requestConfigurationDictionary["tag_for_child_directed_treatment"];
int tagForUnderAgeOfConsent = requestConfigurationDictionary["tag_for_under_age_of_consent"];

Steps to reproduce

Use default request configuration to setup.

Additional context

No response

@abcjjy abcjjy added the bug Something isn't working label Jun 3, 2024
@abcjjy abcjjy changed the title [BUG] RequestConfiguration is set to wrong value [BUG] RequestConfiguration is set to improper default value Jun 3, 2024
@abcjjy abcjjy changed the title [BUG] RequestConfiguration is set to improper default value [BUG] RequestConfiguration is set to inappropriate default value Jun 3, 2024
@abcjjy
Copy link
Author

abcjjy commented Jun 4, 2024

I made a pull request to fix this, #104

@gumaciel
Copy link
Contributor

Thank you I will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants