Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect signal being emitted in v2 #105

Open
WolfgangSenff opened this issue Aug 7, 2024 · 1 comment
Open

[BUG] Incorrect signal being emitted in v2 #105

WolfgangSenff opened this issue Aug 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@WolfgangSenff
Copy link

Godot version

3.5.3

Plugin version

v2.1.0

Phone information

All iOS devices

Issue description

When the GAD delegate calls to https://developers.google.com/admob/ios/api/reference/Protocols/GADFullScreenContentDelegate#-ad:didfailtopresentfullscreencontentwitherror:, the plugin fires the interstitial_failed_to_load signal. However, because it's attempting to present it, it should be interstitial_failed_to_show. This is of course in an older version, but is a simple fix, and I'm happy to open a PR for it, just can't at the moment due to having to find a work-around for this in my app.

Steps to reproduce

The issue is right here:

AdMob::get_singleton()->emit_signal("interstitial_failed_to_load", (int) error.code);

Further, you can see that it's probably not intended to be load by looking at this line, which is firing the same signal, but correctly from the load call:

AdMob::get_singleton()->emit_signal("interstitial_failed_to_load", (int) error.code);

Additional context

If you're willing to make a new release and don't have time to fix this yourself, I'm happy to open a PR. Let me know!

@WolfgangSenff WolfgangSenff added the bug Something isn't working label Aug 7, 2024
@gumaciel
Copy link
Contributor

gumaciel commented Aug 8, 2024

Thank you for opening this issue, It would be awesome if you open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants