Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin #103

Open
maxs15 opened this issue Sep 24, 2015 · 2 comments
Open

Plugin #103

maxs15 opened this issue Sep 24, 2015 · 2 comments

Comments

@maxs15
Copy link
Contributor

maxs15 commented Sep 24, 2015

hi @poiuytrez,

Could you please update the current version and create a tag (3.0.3 maybe?)
I'm working on a new pull request that should fix the issues with the callbacks, I will increment the version as well in the PR.

Thanks :)

@poiuytrez
Copy link
Owner

Hi maxs15,

What do you mean by "update the current version"? Why do we need to have a tag to include the PR?

Thank you !

@maxs15
Copy link
Contributor Author

maxs15 commented Sep 25, 2015

I mean tagging the commits with a version at least for the major modifications.
People would be then able to download the version they need and we would be able to track bugs more easily.
For example, when you merged this commit @84a421f8c7fa9 you introduced a breaking change because the billing key handling changed.
With a new version release people can still target the version they need and at least be aware of change.
So much easier to deal with versions instead of commits id :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants