Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO_BLOCKER] Red0ne's Iteration16 TODOs #572

Closed
14 of 15 tasks
red-0ne opened this issue Jun 3, 2024 · 2 comments
Closed
14 of 15 tasks

[TODO_BLOCKER] Red0ne's Iteration16 TODOs #572

red-0ne opened this issue Jun 3, 2024 · 2 comments
Assignees
Labels
code health Cleans up some code

Comments

@red-0ne
Copy link
Contributor

red-0ne commented Jun 3, 2024

Objective

Tackle all on-chain blockers assigned to red-0ne

Origin Document

Goals

  • Tackle all major TODO's in the codebase assigned to red-0ne

Deliverables

The output of the following command from #577:

grep -r "TODO_BLOCKER(@red-0ne)" . | sed 's/^/- [ ] `/' | sed 's/:/`:/'
  • ./x/tokenomics/keeper/keeper_test.go: // TODO_BLOCKER(@red-0ne): Use the governance parameters for more
  • ./x/tokenomics/keeper/keeper_test.go: // TODO_BLOCKER(@red-0ne): Use the governance parameters for more precise block heights once they are implemented.
  • ./x/tokenomics/keeper/keeper_test.go: // TODO_BLOCKER(@red-0ne): Use the governance parameters for more precise block heights once they are implemented.
  • ./x/tokenomics/keeper/keeper_test.go: // TODO_BLOCKER(@red-0ne): Use the governance parameters for more precise block heights once they are implemented.
  • ./x/supplier/config/supplier_configs_reader.go: // TODO_BLOCKER(@red-0ne): This hasn't been implemented yet but is part of the
  • ./x/proof/keeper/msg_server_submit_proof.go: // TODO_BLOCKER(@red-0ne): Fetch the correct ring for the session this relay is from.
  • ./pkg/partials/payloads/rest.go: // TODO_BLOCKER(@red-0ne): Implement this function
  • ./pkg/partials/payloads/rest.go: // TODO_BLOCKER(@red-0ne): Implement this function
  • ./pkg/partials/payloads/rest.go: // TODO_BLOCKER(@red-0ne): Implement this method
  • ./pkg/partials/payloads/rest.go: // TODO_BLOCKER(@red-0ne): Implement this method
  • ./pkg/partials/payloads/jsonrpc.go: // TODO_BLOCKER(@red-0ne): Implement this method
  • ./pkg/partials/partial.go:// TODO_BLOCKER(@red-0ne): This function currently only supports JSON-RPC and must
  • ./pkg/partials/partial.go: // TODO_BLOCKER(@red-0ne): Handle other request types
  • ./testutil/testproxy/relayerproxy.go:// TODO_BLOCKER(@red-0ne): This function only supports JSON-RPC requests and
  • ./e2e/tests/session.feature:# TODO_BLOCKER(@red-0ne): Make sure to implement and validate this test

Creator: @red-0ne

@red-0ne red-0ne added the code health Cleans up some code label Jun 3, 2024
@red-0ne red-0ne added this to the Shannon Alpha TestNet Launch milestone Jun 3, 2024
@red-0ne red-0ne self-assigned this Jun 3, 2024
@Olshansk Olshansk changed the title [TODOs] Red0ne's TODOs to address [TODO_BLOCKER] Red0ne's Iteration #16 TODOs Jun 4, 2024
@Olshansk Olshansk changed the title [TODO_BLOCKER] Red0ne's Iteration #16 TODOs [TODO_BLOCKER] Red0ne's Iteration16 TODOs Jun 4, 2024
@Olshansk
Copy link
Member

Olshansk commented Jun 4, 2024

@red-0ne I recommend running grep -r "TODO_BLOCKER(@red-0ne )" . | sed 's/^/- [ ] /' | sed 's/:/:/' to update the deliervables after #577 is merged in.

@red-0ne
Copy link
Contributor Author

red-0ne commented Jul 16, 2024

Closed as per #694

@red-0ne red-0ne closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants