-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Protocol] Enforce that a service exists before a supplier can stake for it #598
Comments
Adding the text from the screenshot for copy-pastability. tl;dr There are no issues but we forgot to add the default services. Thanks for bringing this up. Going to sync on it with @kdas next week. For reference, this is how you can query services: poktrolld q service all-services --node=https://testnet-validated-validator-rpc.poktroll.com The service add fee is currently Funding poktrolld tx bank send pnf pokt1d22c8k8nytmzssmzede29exmxmrtv5hdy082gz 2000000000upokt --node=https://testnet-validated-validator-rpc.poktroll.com --keyring-dir=/Users/olshansky/.ignite/accounts --keyring-backend=test --from pnf And then I add the service like so: poktrolld tx service add-service olsh "Olshansky Service" --node=https://testnet-validated-validator-rpc.poktroll.com --from source_owner --keyring-dir=/Users/olshansky/.ignite/accounts --keyring-backend=test So when you query services now, you should see: pagination:
total: "1"
service:
- id: olsh
name: Olshansky Service @yn_alex If you want to add a few services, drop your testnet address here and I'll send you funds. The faucet won't be enough for it. I'll coordinate with @kdas next week to udpate all the things (configs, docs, instructions, etc...) |
Who in this context is a "source owner"? Right now, PNF is the one who authorize of new ServiceIDs in Morse, is this to match that in Shannon? |
It is the Copy-pasting the definition for a better reader experience: // MsgAddService defines a message for adding a new message to the network.
// Services can be added by any actor in the network making them truly
// permissionless.
// TODO_BETA: Add Champions / Sources once its fully defined.
message MsgAddService {
option (cosmos.msg.v1.signer) = "address"; // https://docs.cosmos.network/main/build/building-modules/messages-and-queries
string address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the service supplier using cosmos' ScalarDescriptor
poktroll.shared.Service service = 2 [(gogoproto.nullable) = false]; // The Service for which the supplier is adding to the network
} Next StepsNext steps would be:
Tangentinal ConversationA conversation we have had yet, which I believe you and I differ on (philosophically) is that:
I have explicitly chosen not to discuss this YET because I thought the conversation was premature and put timeslines at risk but have a personal TODO to tend to it. If you think now is the right time to shift focus to this discussion, let's open up an action item (i.e. github issue) whose deliverable will be to align on a decision for this. |
Closed as per #693 |
Objective
Ensure that when a supplier stakes for a new service, a source owner has already added it.
Origin Document
This is to prevent unauthorized service staking by suppliers. [Add link or screenshot if applicable]
See this conversation that surfaced this issue.
Goals
Deliverables
Non-goals / Non-deliverables
General deliverables
Creator: @Olshansk
Co-Owners: @moatus
The text was updated successfully, but these errors were encountered: