Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bitwise aggregation #5009

Closed
jg2562 opened this issue Sep 28, 2022 · 4 comments
Closed

Implement bitwise aggregation #5009

jg2562 opened this issue Sep 28, 2022 · 4 comments
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature P-low Priority: low

Comments

@jg2562
Copy link

jg2562 commented Sep 28, 2022

Problem Description

Implement "bitwise and" and "bitwise or" aggregation for expressions and series. This would be similar to the bitwise reduction in numpy with np.bitwise_or.reduce(arr). This is very helpful for any data measured about bits themselves or packed into bits. "bitwise xor" might also be something to consider.

Potentially also allowing for bit shifts with expressions would be very helpful as well.

@jg2562 jg2562 added the feature label Sep 28, 2022
@zundertj zundertj added enhancement New feature or an improvement of an existing feature and removed feature labels Oct 8, 2022
@Gigioliva
Copy link

👍🏼 this feature would be really useful 🙏🏼

@jg2562
Copy link
Author

jg2562 commented Feb 2, 2023

Another potentially helpful function would be bit_count (aka population count) where it sums the number of set bits within a number. I could also try to implement this, but im not sure where to begin if someone could point me in the right direction

@stinodego stinodego added needs decision Awaiting decision by a maintainer accepted Ready for implementation labels Feb 7, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Feb 9, 2024
@stinodego stinodego added P-low Priority: low and removed needs decision Awaiting decision by a maintainer labels Feb 9, 2024
@stinodego
Copy link
Member

This feature is welcome. We can start with bit_and, bit_or, and bit_xor. Other bit aggregations can be considered at a later point.

@coastalwhite
Copy link
Collaborator

This was implemented by #18994.

@github-project-automation github-project-automation bot moved this from Ready to Done in Backlog Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature P-low Priority: low
Projects
Archived in project
Development

No branches or pull requests

5 participants