Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring plans #6

Open
poldrack opened this issue May 25, 2020 · 3 comments
Open

refactoring plans #6

poldrack opened this issue May 25, 2020 · 3 comments

Comments

@poldrack
Copy link
Owner

poldrack commented May 25, 2020

The initial release of the code (1.0a0) leaves a lot to be desired. In the next few weeks I am planning to refactor it, with a few goals in mind:

  • define Publications class

    • move away from using DOIs as index - use a hash instead
  • define Researcher class

  • separate downloading from rendering
    -- ultimately would like to be able to render to generic markup (e.g. using jinja2) but probably won't get there for this next version.

  • better command line interface

    • allow specification of:
      • base directory
      • template file
  • need to rethink docker workflow. right now, the calls to docker use the version of the package that is installed within the container, rather than the current version on the host system, which could lead to version mismatches.

  • Modularity (suggested by @chrisgorgo): try driving the refactor by making it easier for people to contribute new modules/components. For example layouts, styles, data sources etc.

  • tests

    • what kinds of tests should we include (beyond an end-to-end smoke test)?
@thesamovar
Copy link

Still haven't had a chance to look at code, but is use of docker necessary? It makes it very tricky for people on Windows to use it, which is a shame.

@poldrack
Copy link
Owner Author

poldrack commented May 25, 2020 via email

@thesamovar
Copy link

It would probably not be too difficult to set it up so that it can be run either inside a docker with auto-installation of latex, or directly on host and you're responsible for setting up latex yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants