Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with con_real generation in 1st level FSF #2

Open
mih opened this issue Jan 14, 2015 · 0 comments
Open

Potential issue with con_real generation in 1st level FSF #2

mih opened this issue Jan 14, 2015 · 0 comments

Comments

@mih
Copy link

mih commented Jan 14, 2015

mk_level1_fsf.py contains this bit in the part that generates custom contrasts.

            for evt in range(nevs):
                if contrasts[c][evt]!=0:
                    outfile.write('set fmri(con_real%d.%d) %s\n'%(contrastctr,con_real_ctr,contrasts[c][evt]))
                    outfile.write('set fmri(con_real%d.%d) 0\n'%(contrastctr,con_real_ctr+1))
                    con_real_ctr+=2

                else:
                    outfile.write('set fmri(con_real%d.%d) 0\n'%(contrastctr,evt+1))

I am not sure whether I fully grok it, but isn't it necessary to increment the con_real_ctr regardless of whether a particular contrast vector element is zero? Otherwise it seems to mess of the con_real specification with duplicate IDs. Moreover, why does it need this special case at all? It should be safe to write out the con_real pair even when the value is zero.

Sorry if this is a false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant