Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds000201 -- missing , after a name in dataset_description.json #6

Closed
yarikoptic opened this issue Aug 29, 2016 · 2 comments
Closed

Comments

@yarikoptic
Copy link

thought it was again utf8 stricking back but it is just a banal missing comma (after Peter's name). since @vsoch liked my screen shots so much, here it is:
screenshot

@vsoch
Copy link

vsoch commented Aug 29, 2016

+1! 🍔

Yes, simple validation of the files should take care of this - we do something similar for experiment factory, the validation function first tries loading the json file, and returns invalid if it doesn't work. It's surprised me how often and easy it is to forget commas, quotes, and the like.

@yarikoptic
Copy link
Author

I think this one is fixed but caused #9 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants