Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #213

Merged
merged 16 commits into from
Apr 2, 2024
Merged

Update workflows #213

merged 16 commits into from
Apr 2, 2024

Conversation

guidoderooij
Copy link
Contributor

@guidoderooij guidoderooij commented Mar 21, 2024

Some issues are reported on the workflows:

  • The workflows were executed on old Node versions. Solution is to only use Node version 18 and 20
  • Old versions of actions were used. Solution is to use the latest versions
  • The end to end tests were failing because it is using an old test framework which is no longer supported. The e2e test is converted to Cypress

After installing VSCode Github Actions extension it appeared that the logic to cache node_modules was incorrect so that is now also fixed (and verified). Additionally because Cypress is used also the ~/.cache folder needs to be cached.

@guidoderooij guidoderooij changed the title Update build workflow Update workflows Mar 21, 2024
@guidoderooij guidoderooij marked this pull request as ready for review March 26, 2024 17:22
cypress/support/e2e.ts Outdated Show resolved Hide resolved
cypress/support/commands.ts Outdated Show resolved Hide resolved
@emielb emielb merged commit 0ad50c1 into main Apr 2, 2024
3 checks passed
@emielb emielb deleted the update-workflows branch April 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants