diff --git a/Cargo.lock b/Cargo.lock index 87196a8463..aa29ace6f8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3196,7 +3196,6 @@ dependencies = [ "pallet-transaction-payment-rpc", "pallet-transaction-payment-rpc-runtime-api", "parity-scale-codec", - "quote", "sc-basic-authorship", "sc-chain-spec", "sc-cli", @@ -3210,7 +3209,6 @@ dependencies = [ "sc-network-sync", "sc-offchain", "sc-rpc", - "sc-rpc-api", "sc-service", "sc-telemetry", "sc-transaction-pool", diff --git a/client/cli/src/frontier_db_cmd/tests.rs b/client/cli/src/frontier_db_cmd/tests.rs index e02c33a1bd..0baa7ed7d0 100644 --- a/client/cli/src/frontier_db_cmd/tests.rs +++ b/client/cli/src/frontier_db_cmd/tests.rs @@ -537,7 +537,7 @@ fn commitment_create() { // Test client. let (c, _) = TestClientBuilder::new().build_with_native_executor::(None); - let mut client = Arc::new(c); + let client = Arc::new(c); // Get some transaction status. let t1 = fp_rpc::TransactionStatus::default(); @@ -612,7 +612,7 @@ fn commitment_update() { // Test client. let (c, _) = TestClientBuilder::new().build_with_native_executor::(None); - let mut client = Arc::new(c); + let client = Arc::new(c); // Get some transaction status. let t1 = fp_rpc::TransactionStatus::default(); @@ -748,7 +748,7 @@ fn mapping_read_works() { // Test client. let (c, _) = TestClientBuilder::new().build_with_native_executor::(None); - let mut client = Arc::new(c); + let client = Arc::new(c); // Get some transaction status. let t1 = fp_rpc::TransactionStatus::default(); diff --git a/client/cli/src/frontier_db_cmd/utils.rs b/client/cli/src/frontier_db_cmd/utils.rs index d5fdf01bf0..21ef8deae2 100644 --- a/client/cli/src/frontier_db_cmd/utils.rs +++ b/client/cli/src/frontier_db_cmd/utils.rs @@ -91,10 +91,6 @@ pub trait FrontierDbMessage { format!("Operation not allowed for non-empty Key `{:?}`", key).into() } - fn one_to_many_error(&self) -> sc_cli::Error { - "One-to-many operation not allowed".into() - } - #[cfg(not(test))] fn confirmation_prompt( &self, diff --git a/client/db/src/kv/upgrade.rs b/client/db/src/kv/upgrade.rs index 3eb1af4775..63cf899c8a 100644 --- a/client/db/src/kv/upgrade.rs +++ b/client/db/src/kv/upgrade.rs @@ -385,7 +385,7 @@ mod tests { .build_with_native_executor::( None, ); - let mut client = Arc::new(client); + let client = Arc::new(client); // Genesis block let chain_info = client.chain_info(); diff --git a/client/mapping-sync/src/kv/worker.rs b/client/mapping-sync/src/kv/worker.rs index 7beccd0f0f..d7cb5968ad 100644 --- a/client/mapping-sync/src/kv/worker.rs +++ b/client/mapping-sync/src/kv/worker.rs @@ -246,7 +246,7 @@ mod tests { // Client let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); // Overrides let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); @@ -388,7 +388,7 @@ mod tests { // Client let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); // Overrides let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); diff --git a/client/mapping-sync/src/sql/mod.rs b/client/mapping-sync/src/sql/mod.rs index 72cb065fc6..31588c8ad9 100644 --- a/client/mapping-sync/src/sql/mod.rs +++ b/client/mapping-sync/src/sql/mod.rs @@ -547,7 +547,7 @@ mod test { // Client let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); // Overrides let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); // Indexer backend @@ -750,7 +750,7 @@ mod test { // Client let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); // Overrides let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); // Indexer backend @@ -954,7 +954,7 @@ mod test { // Client let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); // Overrides let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); // Indexer backend @@ -1120,7 +1120,7 @@ mod test { // Client let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); // Overrides let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); // Indexer backend @@ -1266,7 +1266,7 @@ mod test { let backend = builder.backend(); let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); let indexer_backend = fc_db::sql::Backend::new( fc_db::sql::BackendConfig::Sqlite(fc_db::sql::SqliteBackendConfig { @@ -1367,7 +1367,7 @@ mod test { let backend = builder.backend(); let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); let indexer_backend = fc_db::sql::Backend::new( fc_db::sql::BackendConfig::Sqlite(fc_db::sql::SqliteBackendConfig { @@ -1482,7 +1482,7 @@ mod test { let backend = builder.backend(); let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); let indexer_backend = fc_db::sql::Backend::new( fc_db::sql::BackendConfig::Sqlite(fc_db::sql::SqliteBackendConfig { @@ -1583,7 +1583,7 @@ mod test { let backend = builder.backend(); let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); let indexer_backend = fc_db::sql::Backend::new( fc_db::sql::BackendConfig::Sqlite(fc_db::sql::SqliteBackendConfig { @@ -1698,7 +1698,7 @@ mod test { let backend = builder.backend(); let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); let indexer_backend = fc_db::sql::Backend::new( fc_db::sql::BackendConfig::Sqlite(fc_db::sql::SqliteBackendConfig { @@ -1799,7 +1799,7 @@ mod test { let backend = builder.backend(); let (client, _) = builder.build_with_native_executor::(None); - let mut client = Arc::new(client); + let client = Arc::new(client); let storage_override = Arc::new(SchemaV3StorageOverride::new(client.clone())); let indexer_backend = fc_db::sql::Backend::new( fc_db::sql::BackendConfig::Sqlite(fc_db::sql::SqliteBackendConfig { diff --git a/client/rpc/src/lib.rs b/client/rpc/src/lib.rs index 28b8ed8a8a..7f1c19f657 100644 --- a/client/rpc/src/lib.rs +++ b/client/rpc/src/lib.rs @@ -187,7 +187,7 @@ pub mod frontier_backend_client { } } - pub async fn native_block_id( + pub async fn native_block_id( client: &C, backend: &dyn fc_api::Backend, number: Option, @@ -219,7 +219,7 @@ pub mod frontier_backend_client { }) } - pub async fn load_hash( + pub async fn load_hash( client: &C, backend: &dyn fc_api::Backend, hash: H256, @@ -243,7 +243,7 @@ pub mod frontier_backend_client { Ok(None) } - pub fn is_canon(client: &C, target_hash: B::Hash) -> bool + pub fn is_canon(client: &C, target_hash: B::Hash) -> bool where B: BlockT, C: HeaderBackend + 'static, @@ -256,7 +256,7 @@ pub mod frontier_backend_client { false } - pub async fn load_transactions( + pub async fn load_transactions( client: &C, backend: &dyn fc_api::Backend, transaction_hash: H256, @@ -389,7 +389,7 @@ mod tests { None, ); - let mut client = Arc::new(client); + let client = Arc::new(client); // Create a temporary frontier secondary DB. let backend = open_frontier_backend::(client.clone(), tmp.into_path()) diff --git a/frame/evm/precompile/dispatch/src/tests.rs b/frame/evm/precompile/dispatch/src/tests.rs index 6073c20531..55b7692262 100644 --- a/frame/evm/precompile/dispatch/src/tests.rs +++ b/frame/evm/precompile/dispatch/src/tests.rs @@ -14,9 +14,6 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. - -#![cfg(test)] - use super::*; use crate::mock::*; diff --git a/frame/evm/src/tests.rs b/frame/evm/src/tests.rs index a8c2405264..f2379c19d5 100644 --- a/frame/evm/src/tests.rs +++ b/frame/evm/src/tests.rs @@ -14,9 +14,6 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. - -#![cfg(test)] - use super::*; use crate::mock::*; diff --git a/frame/hotfix-sufficients/src/benchmarking.rs b/frame/hotfix-sufficients/src/benchmarking.rs index 6074140ce0..ed2dd1c506 100644 --- a/frame/hotfix-sufficients/src/benchmarking.rs +++ b/frame/hotfix-sufficients/src/benchmarking.rs @@ -14,9 +14,6 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. - -#![cfg(feature = "runtime-benchmarks")] - use frame_benchmarking::{benchmarks, impl_benchmark_test_suite}; use super::*; diff --git a/precompiles/macro/src/precompile/attr.rs b/precompiles/macro/src/precompile/attr.rs index d8a1a300d4..bd366bc5e1 100644 --- a/precompiles/macro/src/precompile/attr.rs +++ b/precompiles/macro/src/precompile/attr.rs @@ -53,7 +53,8 @@ pub mod keyword { syn::custom_keyword!(pre_check); } -/// Attributes for methods. +/// Attributes for methods +#[allow(dead_code)] pub enum MethodAttr { Public(Span, syn::LitStr), Fallback(Span), @@ -106,6 +107,7 @@ impl syn::parse::Parse for MethodAttr { } /// Attributes for the main impl Block. +#[allow(dead_code)] pub enum ImplAttr { PrecompileSet(Span), TestConcreteTypes(Span, Vec), diff --git a/template/node/Cargo.toml b/template/node/Cargo.toml index 21f3cc1aa4..9fb3591e2d 100644 --- a/template/node/Cargo.toml +++ b/template/node/Cargo.toml @@ -19,7 +19,6 @@ futures = { workspace = true } hex-literal = { workspace = true } jsonrpsee = { workspace = true, features = ["server", "macros"] } log = { workspace = true } -quote = { workspace = true } scale-codec = { package = "parity-scale-codec", workspace = true } serde_json = { workspace = true, features = ["arbitrary_precision"] } @@ -38,7 +37,6 @@ sc-network = { workspace = true } sc-network-sync = { workspace = true } sc-offchain = { workspace = true } sc-rpc = { workspace = true } -sc-rpc-api = { workspace = true } sc-service = { workspace = true } sc-telemetry = { workspace = true } sc-transaction-pool = { workspace = true } diff --git a/template/node/src/service.rs b/template/node/src/service.rs index c77e1b5d09..93bfa96101 100644 --- a/template/node/src/service.rs +++ b/template/node/src/service.rs @@ -380,7 +380,7 @@ where ); } - let role = config.role.clone(); + let role = config.role; let force_authoring = config.force_authoring; let name = config.network.node_name.clone(); let frontier_backend = Arc::new(frontier_backend);