Adds Snowbridge to Kusama and Polkadot Runtimes #130

claravanstaden · 2023-12-22T14:45:50Z

Adds asset hub and bridge hub to Kusama and Polkadot runtimes
based off Added Polkadot <> Kusama bridge configuration #108 - needs to be merged first
snowbridge crates needs to be published on crates.io - depends on polkadot-sdk 1.7.0
MessageQueue Pallet is not configured on Kusama and Polkadot asset hub - added in Upgrade to latest [email protected] release #137
FeeManager handle_fee misses reason, crate needs to be updated I think

cc @vgeddes @alistair-singh @yrong @musnit

bkontur · 2024-01-23T12:26:05Z

There is bump to [email protected] with MessageQueues here,
So, I would maybe suggest rebasing this PR on the current main and merging #137 into this PR—it will bring us a little bit closer to the end :)

After #137 is merged, we just need to bump to [email protected].

…ins)

Co-authored-by: Ross Bulat <[email protected]>

…o-1.7

…otal_issuance)

…ators)

# Conflicts: # Cargo.lock # relay/kusama/constants/Cargo.toml # relay/polkadot/constants/Cargo.toml # system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs # system-parachains/bridge-hubs/bridge-hub-kusama/tests/tests.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/xcm_config.rs

# Conflicts: # Cargo.lock # relay/kusama/constants/Cargo.toml # relay/polkadot/constants/Cargo.toml # system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

…-pk-bridge-snowbridge

# Conflicts: # CHANGELOG.md # integration-tests/emulated/chains/parachains/testing/penpal/Cargo.toml # system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/lib.rs

…bko-snowbridge-nits

…oreign_asset_pallet_deposit` to the AH runtimes

…-pk-bridge-snowbridge

Nits for Snowbridge + stuff moving around

bkontur

lgtm, just left few nits plus Snowfork#4

bkontur · 2024-03-20T12:51:14Z

system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs

+			/// User fee for ERC20 token transfer back to Ethereum.
+			/// Configure the fee to max Balance so that it is disabled.
+			/// Sensible value was 2_750_872_500_000.


This is not just about ERC20 token, this fee is applied whatever transfer we will do to the Ethereum with BridgeTable.
And all other tokens are disabled also, unless the governance sets the fee, right?
What does it mean "Sensible value was...."?

I would suggest to update this doc and also for AHP.

bkontur · 2024-03-20T14:41:17Z

system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs

+	snowbridge_pallet_system::migration::v0::InitializeOnUpgrade<
+		Runtime,
+		ConstU32<BRIDGE_HUB_ID>,
+		ConstU32<ASSET_HUB_ID>,
+	>,


@claravanstaden Is this a one-time shot, or do we need it for every runtime upgrade? If it's the former, please move it before // permanent

bkontur · 2024-03-20T14:46:09Z

system-parachains/bridge-hubs/bridge-hub-kusama/tests/tests.rs

@@ -326,6 +328,21 @@ pub fn can_calculate_weight_for_paid_export_message_with_reserve_transfer() {
 	)
 }

+#[test]
+fn change_ethereum_gateway_by_governance_works() {


@claravanstaden very nit, why not to move it to the tests/snowbridge.rs also for BHP

Fixes

acatangiu · 2024-03-21T07:20:55Z

@claravanstaden I think this is ready to merge now, yes?

claravanstaden · 2024-03-21T07:22:21Z

@acatangiu yes, thank you!

acatangiu · 2024-03-21T07:33:03Z

/merge

fellowship-merge-bot · 2024-03-21T07:34:24Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

claravanstaden changed the title ~~Adds Snowbridge (based on Kusama <-> Polkadot bridge PR)~~ Draft - Adds Snowbridge (based on Kusama <-> Polkadot bridge PR) Dec 22, 2023

bkontur mentioned this pull request Jan 4, 2024

single PR on polkadot-sdk version update #101

Open

claravanstaden mentioned this pull request Jan 15, 2024

Adds Snowbridge #126

Closed

claravanstaden mentioned this pull request Jan 26, 2024

Upgrade Kusama and Polkadot runtimes to use MessageQueue Pallet #162

Closed

claravanstaden force-pushed the sv-pk-bridge-snowbridge branch 4 times, most recently from 2aff354 to 4fcef54 Compare January 26, 2024 13:21

claravanstaden force-pushed the sv-pk-bridge-snowbridge branch from c9df1c2 to 237f0ca Compare February 5, 2024 13:18

claravanstaden closed this Feb 13, 2024

claravanstaden deleted the sv-pk-bridge-snowbridge branch February 13, 2024 11:24

claravanstaden restored the sv-pk-bridge-snowbridge branch February 13, 2024 11:25

claravanstaden reopened this Feb 13, 2024

bkontur and others added 16 commits February 16, 2024 14:10

[xcm] adapt paritytech/polkadot-sdk#2428 (ParentRelayOrSiblingParacha…

44eefcc

…ins)

Change TreasuryArguments for collectives

3170733

[bridges] Removed older TODO for bridges fees estimation

a0a61ae

Updated TODOs

b987e8d

Update relay/kusama/src/lib.rs

4cb2d2a

Co-authored-by: Ross Bulat <[email protected]>

Update relay/polkadot/src/lib.rs

c724e91

Co-authored-by: Ross Bulat <[email protected]>

Update relay/polkadot/src/lib.rs

b6293a7

Co-authored-by: Ross Bulat <[email protected]>

Update relay/kusama/src/lib.rs

e3a80b5

Co-authored-by: Ross Bulat <[email protected]>

Merge remote-tracking branch 'origin/bko-bump-to-1.6' into bko-bump-t…

cdd6bf7

…o-1.7

[pallet_balances] adapt paritytech/polkadot-sdk#2657 (removed MaxHolds)

703e674

WIP: XCMv4 renaming

494849b

[pallet_balances] adjust paritytech/polkadot-sdk#3001 (force_adjust_t…

f24c821

…otal_issuance)

[parachains_shared] adapt paritytech/polkadot-sdk#2889 (DisabledValid…

8dccb71

…ators)

Merge branch 'bko-bump-to-1.7' into sv-pk-bridge-snowbridge

e3efa67

# Conflicts: # Cargo.lock # relay/kusama/constants/Cargo.toml # relay/polkadot/constants/Cargo.toml # system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

merge fixes

838bfde

claravanstaden and others added 18 commits March 19, 2024 12:25

Merge remote-tracking branch 'origin/sv-pk-bridge-snowbridge' into sv…

0b550be

…-pk-bridge-snowbridge

merge damage

1694e66

fix runtime tests

890f49d

fix integration tests

3bd0619

Constants moving around

fb7a5d4

Merge remote-tracking branch 'snowfork/sv-pk-bridge-snowbridge' into …

a6b1554

…bko-snowbridge-nits

Move bridge_hub_inbound_queue_pallet_index_is_correct to the runtimes

d326e77

Move `bridge_hub_inbound_queue_deposit_config_is_equal_to_asset_hub_f…

115c3ff

…oreign_asset_pallet_deposit` to the AH runtimes

Move CreateAssetDeposit around

853d17d

Merge branch 'main' into sv-pk-bridge-snowbridge

bcee3e3

fix xcm fee manager impl and adds tests

336acb0

Merge remote-tracking branch 'origin/sv-pk-bridge-snowbridge' into sv…

467fb6d

…-pk-bridge-snowbridge

Merge pull request #3 from bkontur/bko-snowbridge-nits

c88230e

Nits for Snowbridge + stuff moving around

Fixes

85b39f3

Revert back deps

e7f9bb5

Unused import

dc9e6bc

Remove import and use directly

3cf807a

bkontur approved these changes Mar 20, 2024

View reviewed changes

claravanstaden and others added 4 commits March 21, 2024 08:00

correct comment

b3d97cf

move snowbridge migrations to unreleased comment

59b3502

Merge pull request #4 from bkontur/bko-snowbridge-nits

904345c

Fixes

move test

756d00b

fellowship-merge-bot bot merged commit 14cd363 into polkadot-fellows:main Mar 21, 2024
33 of 34 checks passed

claravanstaden deleted the sv-pk-bridge-snowbridge branch March 21, 2024 07:40

claravanstaden mentioned this pull request Apr 10, 2024

Transact from eth to sub Snowfork/polkadot-sdk#114

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Snowbridge to Kusama and Polkadot Runtimes #130

Adds Snowbridge to Kusama and Polkadot Runtimes #130

claravanstaden commented Dec 22, 2023 •

edited

Loading

bkontur commented Jan 23, 2024

bkontur left a comment

bkontur Mar 20, 2024

claravanstaden Mar 21, 2024

bkontur Mar 20, 2024

claravanstaden Mar 21, 2024

bkontur Mar 20, 2024

claravanstaden Mar 21, 2024

acatangiu commented Mar 21, 2024

claravanstaden commented Mar 21, 2024

acatangiu commented Mar 21, 2024

fellowship-merge-bot bot commented Mar 21, 2024

Adds Snowbridge to Kusama and Polkadot Runtimes #130

Adds Snowbridge to Kusama and Polkadot Runtimes #130

Conversation

claravanstaden commented Dec 22, 2023 • edited Loading

bkontur commented Jan 23, 2024

bkontur left a comment

Choose a reason for hiding this comment

bkontur Mar 20, 2024

Choose a reason for hiding this comment

claravanstaden Mar 21, 2024

Choose a reason for hiding this comment

bkontur Mar 20, 2024

Choose a reason for hiding this comment

claravanstaden Mar 21, 2024

Choose a reason for hiding this comment

bkontur Mar 20, 2024

Choose a reason for hiding this comment

claravanstaden Mar 21, 2024

Choose a reason for hiding this comment

acatangiu commented Mar 21, 2024

claravanstaden commented Mar 21, 2024

acatangiu commented Mar 21, 2024

fellowship-merge-bot bot commented Mar 21, 2024

claravanstaden commented Dec 22, 2023 •

edited

Loading