-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated review-bot to 2.3.1 #132
Merged
bkchr
merged 7 commits into
polkadot-fellows:main
from
Bullrich:bullrich/review-bot/2.3.1
Jan 4, 2024
Merged
Updated review-bot to 2.3.1 #132
bkchr
merged 7 commits into
polkadot-fellows:main
from
Bullrich:bullrich/review-bot/2.3.1
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
approved these changes
Jan 3, 2024
joepetrowski
approved these changes
Jan 3, 2024
/merge |
Enabled Available commands
For more information see the documentation |
This will fix the problem reported in #115 Unfortunately @joepetrowski's approval won't count until this is merged as his identity is a sub identity (this pr will fix that). |
xlc
approved these changes
Jan 3, 2024
bkchr
approved these changes
Jan 3, 2024
bkchr
approved these changes
Jan 3, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated review bot to version 2.3.1 which contains the fix for paritytech/review-bot#107.
When a fellow's identity is empty, it will search for a sub identity and try to extract the handle from such subidentity.
I have also added @ggwpez's brilliant site to the readme so the fellow's can see their list of identities (as I don't have any up-to-date listing myself).