Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated review-bot to 2.3.1 #132

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jan 3, 2024

Updated review bot to version 2.3.1 which contains the fix for paritytech/review-bot#107.

When a fellow's identity is empty, it will search for a sub identity and try to extract the handle from such subidentity.

I have also added @ggwpez's brilliant site to the readme so the fellow's can see their list of identities (as I don't have any up-to-date listing myself).

README.md Outdated Show resolved Hide resolved
@Bullrich
Copy link
Contributor Author

Bullrich commented Jan 3, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 3, 2024 19:20
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@Bullrich
Copy link
Contributor Author

Bullrich commented Jan 3, 2024

This will fix the problem reported in #115

Unfortunately @joepetrowski's approval won't count until this is merged as his identity is a sub identity (this pr will fix that).

@ggwpez ggwpez requested a review from bkchr January 3, 2024 22:22
@bkchr bkchr disabled auto-merge January 3, 2024 23:24
@bkchr bkchr enabled auto-merge (squash) January 3, 2024 23:25
ggwpez and others added 4 commits January 4, 2024 11:10
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@bkchr bkchr merged commit 8e03e81 into polkadot-fellows:main Jan 4, 2024
13 checks passed
@Bullrich Bullrich deleted the bullrich/review-bot/2.3.1 branch January 4, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants