-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enable try-runtime idempotency check #133
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Looks like the spec-version check fails. Should i just bump all the versions by one in this MR or disable the check again @bkchr ? |
IMO it would cool if we could enable this check optionally based on if the pr wants to release a new version. See here on how to detect if the changelog changes from unreleased to "released". |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Not sure if it's the right place to raise this question, but it's close enough. Currently, #56 bumps @ordian do we need to push with |
I guess we have to delete it manually this time? |
Not sure I follow, what do we delete manually? |
The migration i mean. We delete it after it executed on-chain. |
Ah yes. We can do that, sure. But that's not the only problem. Your PR enables mandatory idempotency checks. And without spec version checking API, my migration cannot be idempotent because the structure updated is not versioned. And that spec version checking API ( |
No. I already told you this in element. Just wait for the next release. |
That's the elaboration of your answer I waited for! 😃 Thanks, we're just postponing it then. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Okay so we basically have to ignore the idempotency check until the next runtime upgrade on Polkadot... I will selectively disable it. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Enable one more check in the CI to ensure that our migrations are idempotent. Can only merge after #118