Clean up undecodable proxy #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
approved these changes
Jan 18, 2024
|
Removing instead via referenda https://polkadot.polkassembly.io/referenda/440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
The key is undecodable because it contains a Proxy with type
SudoBalanceswhich then also failed to migrate in paritytech/polkadot-sdk@cf4c744 due to the type being removed from the runtime at the same time as the migration was added to the runtime. See the linked issue for details.As the offending proxy belongs being a dormant, old sudo account and is almost certainly not needed, in the interests of keeping this PR simple and minimising time spent on this issue I opted to just delete the undecodable key. If deemed worth the time, I could instead properly migrate the proxy / unreserve the locked funds from it but I doubt this is necessary.