Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try-runtime CI job for checking the migrations #70

Closed
bkchr opened this issue Oct 19, 2023 · 1 comment · Fixed by #75
Closed

Add try-runtime CI job for checking the migrations #70

bkchr opened this issue Oct 19, 2023 · 1 comment · Fixed by #75
Labels
enhancement New feature or request

Comments

@bkchr
Copy link
Contributor

bkchr commented Oct 19, 2023

We should add some CI job that is running try-runtime to check if all migrations are correct.

CC @liamaharon maybe something that you could do?
@bkchr bkchr added the enhancement New feature or request label Oct 19, 2023
@liamaharon
Copy link
Contributor

liamaharon commented Oct 19, 2023 •
edited
Loading

Sure, already on my todo list I will bump the priority

@liamaharon liamaharon mentioned this issue Oct 24, 2023
Merged
@bkchr bkchr closed this as completed in #75 Nov 22, 2023
bkchr added a commit that referenced this issue Nov 22, 2023
@liamaharon @ggwpez
@ordian @bkchr
Fix migrations and add migration CI checks (#75)
569787c 
Closes #70 

The error with Asset Hub Kusama will be fixed when [this
commit](paritytech/polkadot-sdk@db3fd68)
lands in the runtime.

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: ordian <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix migrations and add migration CI checks liamaharon/runtimes
2 participants
@bkchr @liamaharon